From: Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: "Zhang, Xiantao" <xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] Move CONFIG_X86 decleration to be x86 specificin configure script
Date: Thu, 06 Dec 2007 13:13:36 -0600 [thread overview]
Message-ID: <1196968416.7402.4.camel@thinkpad> (raw)
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDCA85AC8-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
On Thu, 2007-12-06 at 11:06 +0800, Zhang, Xiantao wrote:
> Jerone Young wrote:
> > # HG changeset patch
> > # User Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> > # Date 1196891226 21600
> > # Node ID a30e578bd6e2cf7599ce0c57066880658ddf2886
> > # Parent b4cf8e05d20b3f4ca658bb4fdf3db3e4393a5d8a
> > Move CONFIG_X86 decleration to be x86 specific in configure script
> >
> > In the configure script CONFIG_X86 is explicitly declared for
> > qemu. Now while today the support for other archs is not exactly
> > in kvm just yet (it's coming)..this shouldn't be specified for
> > everyone ;-)
> >
> > Signed-off-by: Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> >
> > diff --git a/configure b/configure
> > --- a/configure
> > +++ b/configure
> > @@ -99,6 +99,7 @@ fi
> > #set parameters compiling
> > if [ "$arch" = "i386" -o "$arch" = "x86_64" ]; then
> > target_exec="x86_64-softmmu"
> > + qemu_cflags+=" -DCONFIG_X86"
>
> Hi, Young
> Are you sure it works for you? Seems in script, it can't
> recognize "+=". Anyway, I also have a fix about it in my patch queue,
> when I do ia64 porting.
Really? Hmmm.. that is valid bash syntax. Seems to work fine when I do
it on the command line. Also seems to work out in my script as well. If
this is the case then maybe it's a newer bash feature.
> Thanks
> Xiantao
>
>
> >
> ------------------------------------------------------------------------
> -
> > SF.Net email is sponsored by: The Future of Linux Business White Paper
> > from Novell. From the desktop to the data center, Linux is going
> > mainstream. Let it simplify your IT future.
> > http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
> > _______________________________________________
> > kvm-devel mailing list
> > kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> > https://lists.sourceforge.net/lists/listinfo/kvm-devel
>
> -------------------------------------------------------------------------
> SF.Net email is sponsored by: The Future of Linux Business White Paper
> from Novell. From the desktop to the data center, Linux is going
> mainstream. Let it simplify your IT future.
> http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
> _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel
-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell. From the desktop to the data center, Linux is going
mainstream. Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
next prev parent reply other threads:[~2007-12-06 19:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 21:50 [PATCH] Move CONFIG_X86 decleration to be x86 specific in configure script Jerone Young
2007-12-06 3:06 ` [PATCH] Move CONFIG_X86 decleration to be x86 specificin " Zhang, Xiantao
[not found] ` <42DFA526FC41B1429CE7279EF83C6BDCA85AC8-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-12-06 19:13 ` Jerone Young [this message]
2007-12-06 19:30 ` Avi Kivity
[not found] ` <47584DBF.40207-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-12-06 21:51 ` Jerone Young
2007-12-07 1:15 ` [PATCH] Move CONFIG_X86 decleration tobe " Zhang, Xiantao
[not found] ` <42DFA526FC41B1429CE7279EF83C6BDCA85D8E-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-12-09 17:10 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196968416.7402.4.camel@thinkpad \
--to=jyoung5-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox