Re: [PATCH] Move CONFIG_X86 decleration to be x86 specificin configure script

[Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>]

 On Thu, 2007-12-06 at 21:30 +0200, Avi Kivity wrote:
> Jerone Young wrote:
> >> Hi, Young 
> >> 	Are you sure it works for you? Seems in script, it can't
> >> recognize "+=".  Anyway, I also have a fix about it in my patch queue,
> >> when  I do ia64 porting.  
> >>     
> >
> > Really? Hmmm.. that is valid bash syntax.  Seems to work fine when I do
> > it on the command line. Also seems to work out in my script as well. If
> > this is the case then maybe it's a newer bash feature.
> >   
> 
> Not all systems use bash.

True, but at the top of the configure script is "#!/bin/bash" :-)

perhaps an easier way is to just do 


qemu_cflags="$qemu_cflags --DCONFIG_X86"

This way there shouldn't be any issues.


Here is a patch:

Signed-off-by: Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

Move CONFIG_X86 decleration to be x86 specific in configure script

In the configure script CONFIG_X86 is explicitly declared for
qemu. 

Signed-off-by: Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>

diff --git a/configure b/configure
--- a/configure
+++ b/configure
@@ -99,6 +99,7 @@ fi
 #set parameters compiling
 if [ "$arch" = "i386" -o "$arch" = "x86_64" ]; then
     target_exec="x86_64-softmmu"
+    qemu_cflags="$qemu_cflags -DCONFIG_X86"
 fi
 
 if [ "$arch" = "ia64" ]; then
@@ -113,7 +114,7 @@ fi
 #configure qemu
 (cd qemu; ./configure --target-list=$target_exec \
     --disable-kqemu \
-    --extra-cflags="-I $PWD/../libkvm $qemu_cflags -DCONFIG_X86" \
+    --extra-cflags="-I $PWD/../libkvm $qemu_cflags" \
     --extra-ldflags="-L $PWD/../libkvm $qemu_ldflags" \
     --enable-kvm --kernel-path="$libkvm_kerneldir" \
     ${enable_alsa:+"--enable-alsa"} \



-------------------------------------------------------------------------
SF.Net email is sponsored by:
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php