From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: Re: [PATCH][UPDATE] kvm-userspace: sync icache for more architectures Date: Thu, 13 Dec 2007 18:12:15 -0600 Message-ID: <1197591136.28334.14.camel@basalt> References: <11975745782686-git-send-email-ehrhardt@linux.vnet.ibm.com> Reply-To: Hollis Blanchard Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , "kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , Avi Kivity , "Zhang, Xiantao" To: Christian Ehrhardt Return-path: In-Reply-To: <11975745782686-git-send-email-ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Thu, 2007-12-13 at 20:36 +0100, Christian Ehrhardt wrote: > @@ -2600,8 +2601,8 @@ void cpu_physical_memory_rw(target_phys_addr_t > addr, uint8_t *buf, > phys_ram_dirty[addr1 >> TARGET_PAGE_BITS] |= > (0xff & ~CODE_DIRTY_FLAG); > } > -#ifdef __ia64__ > - kvm_sync_icache((unsigned long)ptr, l); > +#ifdef USE_KVM > + flush_icache_range((unsigned long)ptr, ((unsigned long)ptr)+l); > #endif > } > } else { A comment to explain why the icache needs flushing only in the KVM case would be useful. Other than that I'm fine with it. Signed-off-by: Hollis Blanchard -- Hollis Blanchard IBM Linux Technology Center ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace