From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: Re: [PATCH][UPDATE] kvm-userspace: sync icache for morearchitectures Date: Mon, 17 Dec 2007 19:56:58 -0600 Message-ID: <1197943018.5026.0.camel@diesel> References: <11975745782686-git-send-email-ehrhardt@linux.vnet.ibm.com> <42DFA526FC41B1429CE7279EF83C6BDCAD01E3@pdsmsx415.ccr.corp.intel.com> <476247EB.9040003@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Avi Kivity , "Zhang, Xiantao" , qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org To: Christian Ehrhardt Return-path: In-Reply-To: <476247EB.9040003-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Fri, 2007-12-14 at 10:07 +0100, Christian Ehrhardt wrote: > > Hollis Blanchard wrote: > > A comment to explain why the icache needs flushing only in the KVM > case > > would be useful. Other than that I'm fine with it. > > > > Signed-off-by: Hollis Blanchard > AFAIK Plain qemu does not directly execute guest code on the > processor, > so the icache is not an issue for it. > Qemu itself has the flush_icache_range function only as helper for the > dynamic code generation. > But we may now write executable guest code with our intercepted mmio > handling that is directly executed when switching back to the guest > context, therefore we need that invalidation in the kvm case. > > For the case that I'm overlooking something in plain qemu, so that it > might need it too I add qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org for comments from there, > but currently I think to have it in #ifdef USE_KVM is the right way. > > > P.S. Hollis did you mean you would like to see a comment in the code > where that call takes place? Yes! Hopefully much shorter than this email... :-P -- Hollis Blanchard IBM Linux Technology Center ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace