Re: building kvm-userspace with separate kernel object directory?

[Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>]

I'm having a hard time parsing this.

Basically this patch is duplicating what Kbuild does: it is creating the
appropriate asm symlink. The original problem was that kvm-userspace
didn't have an asm symlink, so the patch does fix it.

-- 
Hollis Blanchard
IBM Linux Technology Center

On Mon, 2008-01-07 at 15:50 -0600, Jerone Young wrote:
> Whoops should have replied to this one.
> 
> So this does not solve the issue. As it point it includes
> <KERNELDIR>/includes .. just you have to compile the kernel directory so
> that  "include/asm" symlink in the kernel directory is made.

I have already done this. The asm symlink is located at
linux/objpowerpcsequoia/include/asm .

> This creates a symlink to the symlink and that symlnk which is already
> in include path -I $(KERNELDIR)/include

It does not create a symlink to a symlink: the link is asm ->
linux/include/asm-foo .

> What would probably be better is to add a check to see if
> <KERNEL_DIR>/include/asm is created. If it's not give the user an error
> to compile there kernel source.

The issue is not that I have not compiled the kernel tree. I HAVE
compiled it, but I used the O= option when doing so.

> On Mon, 2008-01-07 at 15:29 -0600, Hollis Blanchard wrote:
> > Create an "asm" symlink from libkvm into the kernel source directory.
> > This allows one to use kernel trees built with the O= option.
> > 
> > Signed-off-by: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> > 
> > ---
> > This is all I can come up with... it should work by accident for user/
> > and qemu/ directories too, since they use "-I ../libkvm".
> > 
> > diff --git a/configure b/configure
> > --- a/configure
> > +++ b/configure
> > @@ -130,6 +130,8 @@ fi
> >            --arch="$arch" \
> >            ${cross_prefix:+"--cross-prefix=$cross_prefix"})
> > 
> > +(cd libkvm; ln -sf "$kerneldir/include/asm-$arch" asm)
> > +
> >  #configure qemu
> >  (cd qemu; ./configure --target-list=$target_exec \
> >      --disable-kqemu \
> > diff --git a/libkvm/Makefile b/libkvm/Makefile
> > --- a/libkvm/Makefile
> > +++ b/libkvm/Makefile
> > @@ -10,7 +10,7 @@ CFLAGS += $(autodepend-flags) -g -fomit-
> >  CFLAGS += $(autodepend-flags) -g -fomit-frame-pointer -Wall
> >  CFLAGS += $(call cc-option, -fno-stack-protector, "")
> >  CFLAGS += $(call cc-option, -fno-stack-protector-all, "")
> > -CFLAGS += -I $(KERNELDIR)/include
> > +CFLAGS += -I $(KERNELDIR)/include -I .
> > 
> >  LDFLAGS += $(CFLAGS)
> > 
> > @@ -35,4 +35,4 @@ install:
> >  -include .*.d
> > 
> >  clean:
> > -       $(RM) *.o *.a .*.d
> > +       $(RM) *.o *.a .*.d asm
> > 



-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace