From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: Re: compile error Date: Wed, 09 Jan 2008 11:03:30 -0600 Message-ID: <1199898210.5637.20.camel@basalt> References: <10EA09EFD8728347A513008B6B0DA77A029F4E20@pdsmsx411.ccr.corp.intel.com> <4784882F.9000103@qumranet.com> Reply-To: Hollis Blanchard Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Avi Kivity Return-path: In-Reply-To: <4784882F.9000103-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Wed, 2008-01-09 at 10:39 +0200, Avi Kivity wrote: > Zhao, Yunfeng wrote: > > Today's tip fails to compile with following error messages: > > > > [...] > > Fixed now. Hollis, I had to revert your asm symlink patch to fix this, > so we need to find an alternative solution to that problem. qemu ends up including from /usr. libkvm, on the other hand, ends up including from the target kernel tree. Since the two components are meaning completely different things when referring to the "asm" directory, we should use different include paths. The best long-term solution would probably be to remove "-I $(KERNELDIR)/include" from libkvm, and instead build against a copy of the KVM headers (maybe copied over with that "make sync" target?). Avi, I think you're responsible for all the build directory munging we do currently; what do you think about that? -- Hollis Blanchard IBM Linux Technology Center ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace