From: Laurent Vivier <Laurent.Vivier-6ktuUTfB/bM@public.gmane.org>
To: Jan Kiszka <jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH] janitor: revert accidental type change
Date: Mon, 21 Jan 2008 14:01:51 +0100 [thread overview]
Message-ID: <1200920511.4577.9.camel@frecb07144> (raw)
In-Reply-To: <47948ECC.9000404-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
Le lundi 21 janvier 2008 à 13:23 +0100, Jan Kiszka a écrit :
> While trying to reduce the warning noise (to identify warnings of
> homebrewed patches), I also came across this bogus but fortunately
> harmless type change in bdrv_commit. Fix below.
>
> Jan
This has already been reported.
Please apply, Avi.
I'm working on a patch to be able to use snapshot=on and cache=off
together, but while I'm fighting against AIO (I've an incomprehensible
EINVAL) you should apply this fix.
Laurent
>
> Index: kvm-userspace/qemu/block.c
> ===================================================================
> --- kvm-userspace.orig/qemu/block.c
> +++ kvm-userspace/qemu/block.c
> @@ -460,7 +460,7 @@ int bdrv_commit(BlockDriverState *bs)
> BlockDriver *drv = bs->drv;
> int64_t i, total_sectors;
> int n, j;
> - unsigned char *sector[512];
> + unsigned char sector[512];
>
> if (!drv)
> return -ENOMEDIUM;
>
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel
next prev parent reply other threads:[~2008-01-21 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 12:23 [PATCH] janitor: revert accidental type change Jan Kiszka
[not found] ` <47948ECC.9000404-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org>
2008-01-21 13:01 ` Laurent Vivier [this message]
2008-01-21 13:20 ` Carlo Marcelo Arenas Belon
2008-01-22 13:33 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1200920511.4577.9.camel@frecb07144 \
--to=laurent.vivier-6ktuutfb/bm@public.gmane.org \
--cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
--cc=jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox