From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [patch 1/6] mmu_notifier: Core code
Date: Wed, 30 Jan 2008 18:10:32 +0100
Message-ID: <1201713032.28547.234.camel@lappy>
References: <20080130022909.677301714@sgi.com>
	 <20080130022944.236370194@sgi.com>  <20080130153749.GN7233@v2.random>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: Christoph Lameter <clameter@sgi.com>, Robin Holt <holt@sgi.com>,
	Avi Kivity <avi@qumranet.com>, Izik Eidus <izike@qumranet.com>,
	Nick Piggin <npiggin@suse.de>, kvm-devel@lists.sourceforge.net,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	steiner@sgi.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	daniel.blueman@quadrics.com, Hugh Dickins <hugh@veritas.com>
To: Andrea Arcangeli <andrea@qumranet.com>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1762834AbYA3RKv@vger.kernel.org>
In-Reply-To: <20080130153749.GN7233@v2.random>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org


On Wed, 2008-01-30 at 16:37 +0100, Andrea Arcangeli wrote:
> On Tue, Jan 29, 2008 at 06:29:10PM -0800, Christoph Lameter wrote:
> > +void mmu_notifier_release(struct mm_struct *mm)
> > +{
> > +	struct mmu_notifier *mn;
> > +	struct hlist_node *n, *t;
> > +
> > +	if (unlikely(!hlist_empty(&mm->mmu_notifier.head))) {
> > +		rcu_read_lock();
> > +		hlist_for_each_entry_safe_rcu(mn, n, t,
> > +					  &mm->mmu_notifier.head, hlist) {
> > +			hlist_del_rcu(&mn->hlist);
> 
> This will race and kernel crash against mmu_notifier_register in
> SMP. You should resurrect the per-mmu_notifier_head lock in my last
> patch (except it can be converted from a rwlock_t to a regular
> spinlock_t) and drop the mmap_sem from
> mmu_notifier_register/unregister.

Agreed, sorry for this oversight.