From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: Re: [PATCH 0 of 3] RFC: creating a particular vcpu type Date: Tue, 05 Feb 2008 13:23:19 -0600 Message-ID: <1202239399.26953.42.camel@basalt> References: <47A89285.40802@us.ibm.com> <1202234014.26953.25.camel@basalt> <47A8A582.5060502@us.ibm.com> Reply-To: Hollis Blanchard Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Avi Kivity To: Anthony Liguori Return-path: In-Reply-To: <47A8A582.5060502-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org On Tue, 2008-02-05 at 12:05 -0600, Anthony Liguori wrote: > > Hollis Blanchard wrote: > > If it's the "ioctl" in the function name you object to, that's > easily > > changed. > > > > It's not the name, it's what you're doing. You're introducing an > architecture specific ioctl that essentially overrides an > common-ioctl(). No, I am introducing an architecture-specific ioctl that shares common code, which after all is the goal. > If anything, I would think it would be better to expand the existing > common-ioctl with the notion and then have a > per-architecture hook within that ioctl. I *am* expanding the common ioctl. I am also preserving the existing ABI: CREATE_VCPU still works, and CREATE_VCPU_TYPE is the new ioctl. And then, voila, we have an architecture-specific hook: kvm_arch_vcpu_create(). I will happily move the KVM_CREATE_VCPU_TYPE case from kvm_arch_vm_ioctl() to kvm_vm_ioctl(), and since the additional parameter is necessarily architecture-specific, it will simply call kvm_arch_vcpu_create_type(). -- Hollis Blanchard IBM Linux Technology Center ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/