From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: Re: [kvm-ppc-devel] [PATCH] Add print for PowerPC qemu for failed DCR read/writes Date: Wed, 06 Feb 2008 11:06:32 -0600 Message-ID: <1202317592.5546.1.camel@basalt> References: <4bbbf98ebf05ef77dbb6.1202249218@thinkpad.austin.ibm.com> <47A99932.3050009@linux.vnet.ibm.com> Reply-To: Hollis Blanchard Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Jerone Young To: Christian Ehrhardt Return-path: In-Reply-To: <47A99932.3050009-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Yeah, rate-limiting makes sense. Maybe we could take it one step further and only print the warning the first time a particular unemulated DCR is accessed. I also agree about the captalization. :) -- Hollis Blanchard IBM Linux Technology Center On Wed, 2008-02-06 at 12:25 +0100, Christian Ehrhardt wrote: > hi Jerone, > I think this is good for debugging to find unsupported hardware, but it should not be enabled by default (you could get a printf storm if a guest workload does stupid things). Maybe qemu has some debug/verbose options you can use. > And additionally it would be useful for the dcr_write patch to print the value it tried to write. > I also don't know if we really need that caps-locked in the output. > > Jerone Young wrote: > > # HG changeset patch > > # User Jerone Young > > # Date 1202249136 21600 > > # Node ID 4bbbf98ebf05ef77dbb68e2131b3bc0764767c99 > > # Parent f8cab6a29bf3f34f1cbf4d1e6d7bd21809fd4184 > > Add print for PowerPC qemu for failed DCR read/writes > > > > This patch adds a print to notify of failed reads and rights. Currently > > we will still ignore them (until development is fully done). But this makes > > them easier to spot. > > > > Signed-off-by: Jerone Young > > > > diff --git a/qemu/qemu-kvm-powerpc.c b/qemu/qemu-kvm-powerpc.c > > --- a/qemu/qemu-kvm-powerpc.c > > +++ b/qemu/qemu-kvm-powerpc.c > > @@ -178,13 +178,17 @@ int handle_powerpc_dcr_read(int vcpu, ui > > int handle_powerpc_dcr_read(int vcpu, uint32_t dcrn, uint32_t *data) > > { > > CPUState *env = cpu_single_env; > > - ppc_dcr_read(env->dcr_env, dcrn, data); > > + if (ppc_dcr_read(env->dcr_env, dcrn, data) < 0) > > + printf("DCR FAILED on READ at 0x%x\n", dcrn); > > + > > return 0; /* XXX ignore failed DCR ops */ > > } > > > > int handle_powerpc_dcr_write(int vcpu, uint32_t dcrn, uint32_t data) > > { > > CPUState *env = cpu_single_env; > > - ppc_dcr_write(env->dcr_env, dcrn, data); > > + if (ppc_dcr_write(env->dcr_env, dcrn, data) < 0) > > + printf("DCR FAILED on WRITE at 0x%x\n", dcrn); > just a suggestion > > printf("%s - failed writing 0x%x @ 0x%x\n", dcrn, data); > > > + > > return 0; /* XXX ignore failed DCR ops */ > > } > > > > ------------------------------------------------------------------------- > > This SF.net email is sponsored by: Microsoft > > Defy all challenges. Microsoft(R) Visual Studio 2008. > > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > > _______________________________________________ > > kvm-ppc-devel mailing list > > kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org > > https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel > ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/