public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Jerone Young <jyoung5@us.ibm.com>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
	kvm-ppc-devel <kvm-ppc-devel@lists.sourceforge.net>,
	Hollis Blanchard <hollisb@us.ibm.com>
Subject: Re: [kvm-ppc-devel] Top level kvm-userspace	directory	getting	crowded ...	need new dir	for qemu dependencies
Date: Thu, 28 Feb 2008 14:28:52 -0600	[thread overview]
Message-ID: <1204230532.12181.40.camel@thinkpad.austin.ibm.com> (raw)
In-Reply-To: <47C66DDA.7000808@qumranet.com>

So I forgot to CC all the interested parties on this list (sorry about
that I wasn't thinking at the time), but I did start up a conversation
on linuxppc-dev on the subject of splitting out libfdt from dtc. Mainly
to get the thought of what the dtc folks thought about splitting out
libfdt.

The outcome of this discussion is the point of libfdt is to be
integrated into different projects. I could not make a good argument at
all as to why it should be split out (actually I did a terrible job at
it :-)). A good analogy was made also as this is "equivalent to
splitting libcrypto out of openssl".

So the concessious from others in the libfdt community is the it should
go in the project. This would be in line with what Hollis has been
saying on the list.

Now for us we can do one of the following options:
1) Integrate libfdt into our kvm-userspace
   or qemu (which would then require going upstream qemu folks also agree).

2) Can use wget or something to first grab the dtc source and get libfdt
from it. Then place in our make file and build it. As well as point
cflags & ldflags to it. (This can be done, though I wanted to avoid
going this route)


Here is a link to the discussion on linuxppc-dev:
http://ozlabs.org/pipermail/linuxppc-dev/2008-February/052262.html


On Thu, 2008-02-28 at 10:16 +0200, Avi Kivity wrote:
> Hollis Blanchard wrote:
> >> It doesn't have to be a package; it can be as simple as a tarball that 
> >> people have to make; && sudo make install before compiling kvm, the same 
> >> as other prerequisite libraries.
> >>     
> >
> > Sure. Let's put that tarball inside the qemu directory, and then have it
> > extracted and built automatically when the user types "make".
> >
> > I'm really not clear on what advantage you think will be gained here.
> >
> >   
> 
> If the package never changes in kvm-specific ways, there is no point in 
> including it in kvm. The user can install it once, just like they 
> install the X devel packages (for example) which we don't carry in kvm 
> either.
> 
> Is it indeed the case that no modifications are needed for kvm?
> 
> >> The barrier should be whether we need to carry local changes or not.  If 
> >> we can use upstream as is, then it should be installed independently.
> >>     
> >
> > So let me get this straight... you think it's cool to awk kernel source,
> >   
> 
> Awking the kernel source is not done for the sheer pleasure of it. It is 
> painful to maintain and I only do it out of necessity.

> 
> > but not to copy library code that was designed to be copied in the first
> > place? Seriously? Would it be more palatable to you if I ran awk over
> > arch/powerpc/boot/libdft?
> >   
> 
> Including the source in kvm is of course preferable to awk, but less 
> preferable to an external dependency.


> 


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  reply	other threads:[~2008-02-28 20:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-25  6:50 Top level kvm-userspace directory getting crowded ... need new dir for qemu dependencies Jerone Young
2008-02-25  9:00 ` Avi Kivity
2008-02-26 17:24   ` Jerone Young
2008-02-27 10:59     ` Avi Kivity
2008-02-27 16:29     ` Hollis Blanchard
2008-02-27 16:34       ` Avi Kivity
2008-02-27 16:48         ` Alexander Graf
2008-02-27 16:59           ` Avi Kivity
2008-02-27 17:07             ` Alexander Graf
2008-02-27 18:56           ` Hollis Blanchard
2008-02-27 19:18             ` Alexander Graf
2008-02-27 20:22               ` [kvm-ppc-devel] " Hollis Blanchard
2008-02-27 21:20                 ` Alexander Graf
2008-02-27 22:19                   ` Hollis Blanchard
2008-02-27 22:32                     ` Alexander Graf
2008-03-02 18:38                     ` Luca Barbato
2008-02-27 19:25             ` Avi Kivity
2008-02-27 19:57               ` [kvm-ppc-devel] " Hollis Blanchard
2008-02-28  8:16                 ` Avi Kivity
2008-02-28 20:28                   ` Jerone Young [this message]
2008-03-02 16:41                     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204230532.12181.40.camel@thinkpad.austin.ibm.com \
    --to=jyoung5@us.ibm.com \
    --cc=avi@qumranet.com \
    --cc=hollisb@us.ibm.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=kvm-ppc-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox