Re: [PATCH] Check device status in tx timer

[Dor Laor <dor.laor@gmail.com>]

On Tue, 2008-03-04 at 09:42 -0600, Anthony Liguori wrote:
> > diff --git a/qemu/hw/virtio-net.c b/qemu/hw/virtio-net.c
> > index 612cf6b..a05eafb 100644
> > --- a/qemu/hw/virtio-net.c
> > +++ b/qemu/hw/virtio-net.c
> > @@ -280,6 +280,10 @@ static void virtio_net_tx_timer(void *opaque)
> >  {
> >      VirtIONet *n = opaque;
> >
> > +    /* Just in case the driver is not ready on more */
> > +    if (!(n->vdev.status & VIRTIO_CONFIG_S_DRIVER_OK))
> > +        return;
> > +
> >   
> 
> You probably want to set tx_timer_active = 0 here too.
> 

yap, thanks.

> Regards,
> 
> Anthony Liguori
> 
> >      n->tx_vq->vring.used->flags &= ~VRING_USED_F_NO_NOTIFY;
> >      n->tx_timer_active = 0;
> >      virtio_net_flush_tx(n, n->tx_vq);
> >
> >   
> 


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/