From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dor Laor <dor.laor@gmail.com>
Subject: Re: [PATCH] Check device status in tx timer
Date: Wed, 05 Mar 2008 00:39:01 +0200
Message-ID: <1204670341.25172.10.camel@localhost.localdomain>
References: <1204644806.19089.44.camel@localhost.localdomain>
	<47CD6DCF.7030008@us.ibm.com>
Reply-To: dor.laor@qumranet.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>
To: Anthony Liguori <aliguori@us.ibm.com>
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
In-Reply-To: <47CD6DCF.7030008@us.ibm.com>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org


On Tue, 2008-03-04 at 09:42 -0600, Anthony Liguori wrote:
> > diff --git a/qemu/hw/virtio-net.c b/qemu/hw/virtio-net.c
> > index 612cf6b..a05eafb 100644
> > --- a/qemu/hw/virtio-net.c
> > +++ b/qemu/hw/virtio-net.c
> > @@ -280,6 +280,10 @@ static void virtio_net_tx_timer(void *opaque)
> >  {
> >      VirtIONet *n = opaque;
> >
> > +    /* Just in case the driver is not ready on more */
> > +    if (!(n->vdev.status & VIRTIO_CONFIG_S_DRIVER_OK))
> > +        return;
> > +
> >   
> 
> You probably want to set tx_timer_active = 0 here too.
> 

yap, thanks.

> Regards,
> 
> Anthony Liguori
> 
> >      n->tx_vq->vring.used->flags &= ~VRING_USED_F_NO_NOTIFY;
> >      n->tx_timer_active = 0;
> >      virtio_net_flush_tx(n, n->tx_vq);
> >
> >   
> 


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/