Re: [kvm-ppc-devel] [PATCH 1 of 7] Add libfdt to KVM userspace

[Hollis Blanchard <hollisb@us.ibm.com>]

On Tue, 2008-03-11 at 23:50 -0500, Jerone Young wrote:
> diff --git a/libfdt/Makefile b/libfdt/Makefile
> new file mode 100644
> --- /dev/null
> +++ b/libfdt/Makefile
> @@ -0,0 +1,19 @@
> +include ../config.mak
> +include ../user/config.mak
> +
> +LIBFDT_OBJS = fdt.o fdt_ro.o fdt_wip.o fdt_sw.o fdt_rw.o fdt_strerror.o
> +
> +LIBFDT_INCLUDES = fdt.h libfdt.h
> +LIBFDT_EXTRA = libfdt_internal.h
> +
> +LIBFDT_LIB = libfdt.a
> +
> +CFLAGS += -I .
> +
> +all: libfdt.a
> +
> +libfdt.a: $(LIBFDT_OBJS)
> +	$(AR) rcs $@ $^
> +
> +clean: 
> +	rm -rf *.o *.a
> diff --git a/libfdt/Makefile.libfdt b/libfdt/Makefile.libfdt
> new file mode 100644
> --- /dev/null
> +++ b/libfdt/Makefile.libfdt
> @@ -0,0 +1,14 @@
> +# Makefile.libfdt
> +#
> +# This is not a complete Makefile of itself.  Instead, it is designed to
> +# be easily embeddable into other systems of Makefiles.
> +#
> +LIBFDT_SRCS = fdt.c fdt_ro.c fdt_wip.c fdt_sw.c fdt_rw.c fdt_strerror.c
> +LIBFDT_INCLUDES = fdt.h libfdt.h
> +LIBFDT_EXTRA = libfdt_internal.h
> +LIBFDT_LIB = libfdt/libfdt.a
> +
> +LIBFDT_OBJS = $(LIBFDT_SRCS:%.c=%.o)
> +
> +$(LIBFDT_objdir)/$(LIBFDT_LIB): $(addprefix $(LIBFDT_objdir)/,$(LIBFDT_OBJS))
> +

Why are you duplicating Makefile.libfdt instead of including it?

-- 
Hollis Blanchard
IBM Linux Technology Center


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/