From: Hollis Blanchard <hollisb@us.ibm.com>
To: Jerone Young <jyoung5@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net, kvm-ppc-devel@lists.sourceforge.net
Subject: Re: [kvm-ppc-devel] [PATCH 3 of 7] Create new load_uimage() & gunzip support to uboot loader in Qemu
Date: Tue, 18 Mar 2008 16:14:24 -0500 [thread overview]
Message-ID: <1205874865.11784.27.camel@basalt> (raw)
In-Reply-To: <25515e6983ba1e070cbd.1205870796@thinkpad.austin.ibm.com>
On Tue, 2008-03-18 at 15:06 -0500, Jerone Young wrote:
> + tmp_loaded_image_size = hdr->ih_size;
> +
> + if (hdr->ih_comp == IH_COMP_GZIP) {
> + uncompressed_data = qemu_malloc(MAX_KERNEL_SIZE);
> + ret = gunzip(uncompressed_data, MAX_KERNEL_SIZE,
> + (unsigned char *) data,
> + &tmp_loaded_image_size);
> +
> + if (ret < 0) {
> + fprintf(stderr, "Unable to decompress gziped image!\n");
> + goto fail;
> + }
> +
> + qemu_free(data);
> + cpu_physical_memory_write_rom(hdr->ih_load, uncompressed_data,
> + tmp_loaded_image_size);
> +
> + }
> + else {
> + cpu_physical_memory_write_rom(hdr->ih_load, data,
> + tmp_loaded_image_size);
> + }
> +
> + if (loaded_image_size != NULL)
> + *loaded_image_size = tmp_loaded_image_size;
> +
> + if ( load_address != NULL)
> + *load_address = hdr->ih_load;
Your whitespace in here is all over the place. Please fix.
--
Hollis Blanchard
IBM Linux Technology Center
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-03-18 21:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-18 20:06 [PATCH 0 of 7] [v3] PowerPC kvm-userspace patches Jerone Young
2008-03-18 20:06 ` [PATCH 1 of 7] Add libfdt to KVM userspace Jerone Young
2008-03-18 20:06 ` [PATCH 2 of 7] Add libfdt support to qemu Jerone Young
2008-03-18 21:16 ` [kvm-ppc-devel] " Hollis Blanchard
2008-03-18 21:22 ` Jerone Young
2008-03-18 21:28 ` Hollis Blanchard
2008-03-18 21:57 ` Jerone Young
2008-03-18 20:06 ` [PATCH 3 of 7] Create new load_uimage() & gunzip support to uboot loader in Qemu Jerone Young
2008-03-18 21:14 ` Hollis Blanchard [this message]
2008-03-18 21:46 ` [kvm-ppc-devel] " Jerone Young
2008-03-18 22:14 ` Hollis Blanchard
2008-03-18 20:06 ` [PATCH 4 of 7] Add PPC 440EP bamboo board device tree source & binary into qemu Jerone Young
2008-03-18 20:06 ` [PATCH 5 of 7] Add dynamic device tree manipulation & change uboot loader for PPC bamboo board model Jerone Young
2008-03-18 21:25 ` [kvm-ppc-devel] " Hollis Blanchard
2008-03-18 21:35 ` Jerone Young
2008-03-18 22:08 ` Hollis Blanchard
2008-03-18 20:06 ` [PATCH 6 of 7] Modify PPC bamboo & ppc440 board models Jerone Young
2008-03-18 20:06 ` [PATCH 7 of 7] Add ability to specify ram on command line for bamboo board model Jerone Young
2008-03-18 21:03 ` [kvm-ppc-devel] " Hollis Blanchard
2008-03-18 21:17 ` Jerone Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205874865.11784.27.camel@basalt \
--to=hollisb@us.ibm.com \
--cc=jyoung5@us.ibm.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=kvm-ppc-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox