From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hollis Blanchard <hollisb@us.ibm.com>
Subject: Re: [kvm-ppc-devel] [PATCH 3 of 7] Create new
	load_uimage() &	gunzip support to uboot	loader in Qemu
Date: Tue, 18 Mar 2008 16:14:24 -0500
Message-ID: <1205874865.11784.27.camel@basalt>
References: <25515e6983ba1e070cbd.1205870796@thinkpad.austin.ibm.com>
Reply-To: Hollis Blanchard <hollisb@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel@lists.sourceforge.net,
	kvm-ppc-devel@lists.sourceforge.net
To: Jerone Young <jyoung5@us.ibm.com>
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
In-Reply-To: <25515e6983ba1e070cbd.1205870796@thinkpad.austin.ibm.com>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org

On Tue, 2008-03-18 at 15:06 -0500, Jerone Young wrote:
> +    tmp_loaded_image_size = hdr->ih_size;
> +    
> +    if (hdr->ih_comp == IH_COMP_GZIP) {
> +       uncompressed_data = qemu_malloc(MAX_KERNEL_SIZE);
> +       ret = gunzip(uncompressed_data, MAX_KERNEL_SIZE,
> +                    (unsigned char *) data, 
> +                    &tmp_loaded_image_size);
> +
> +       if (ret < 0) {
> +            fprintf(stderr, "Unable to decompress gziped image!\n");
> +            goto fail;
> +        }
> +
> +        qemu_free(data);
> +        cpu_physical_memory_write_rom(hdr->ih_load, uncompressed_data,
> +                                      tmp_loaded_image_size);
> +
> +    }
> +    else {
> +        cpu_physical_memory_write_rom(hdr->ih_load, data, 
> +                                      tmp_loaded_image_size);
> +    }
> +
> +    if (loaded_image_size != NULL)
> +        *loaded_image_size = tmp_loaded_image_size;
> +   
> +    if ( load_address != NULL)
> +       *load_address = hdr->ih_load;

Your whitespace in here is all over the place. Please fix.

-- 
Hollis Blanchard
IBM Linux Technology Center


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/