From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: Re: [kvm-ppc-devel] [PATCH 2 of 7] Add libfdt support to qemu Date: Tue, 18 Mar 2008 16:28:05 -0500 Message-ID: <1205875685.11784.39.camel@basalt> References: <1205874964.11784.30.camel@basalt> <1205875340.23113.12.camel@thinkpad.austin.ibm.com> Reply-To: Hollis Blanchard Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net, kvm-ppc-devel@lists.sourceforge.net To: jyoung5@us.ibm.com Return-path: In-Reply-To: <1205875340.23113.12.camel@thinkpad.austin.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org OK, if that's acceptable to the qemu folks, could you put that in the patch description? -- Hollis Blanchard IBM Linux Technology Center On Tue, 2008-03-18 at 16:22 -0500, Jerone Young wrote: > So this is the code Anthony asked for for probing libfdt. The problem is > that if you do ./configure at kvm-userpace top directory for > the first time or after a clean you do not have libfdt.a. When qemu > configure is run this probe would allways fail. So to check we just > check for the header. So we compile a very simple program that include > libfdt.h as the test. > > All the XXX are if we ever do break libfdt out then we can do the proper > probing for it (and the code for it is ready to be uncommented). > > > On Tue, 2008-03-18 at 16:16 -0500, Hollis Blanchard wrote: > > On Tue, 2008-03-18 at 15:06 -0500, Jerone Young wrote: > > > +###################################### > > > +# libfdt probe > > > +# > > > +if test -z "$device_tree_support" -a \ > > > + "$cpu" = "powerpc"; then > > > + device_tree_support="no" > > > + cat > $TMPC << EOF > > > +#include > > > +/* XXX uncomment later when libfdt is built before this test */ > > > +//int main(void) { void *fdt; return fdt_create(fdt, 1024); } > > > +int main (void) {return 0;} > > > +EOF > > > +# XXX for now do not try to link to libfdt and just check for header */ > > > +# if $cc $ARCH_CFLAGS $CFLAGS $LDFLAGS -o $TMPE $TMPC -lfdt 2> /dev/null ; then > > > + if $cc $ARCH_CFLAGS $CFLAGS $LDFLAGS -o $TMPE $TMPC 2> /dev/null; then > > > + device_tree_support="yes" > > > + else > > > + echo > > > + echo "Error: Could not find libfdt" > > > + echo "Make sure to have the libfdt libs and headers installed." > > > + echo > > > + exit 1 > > > + fi > > > +fi > > > > What is the problem here? Should you describe it in the patch > > description? Did you mean to fix this before committing? > > > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > _______________________________________________ > kvm-ppc-devel mailing list > kvm-ppc-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/kvm-ppc-devel ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/