public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Dor Laor <dor.laor@gmail.com>
To: kvm-devel <kvm-devel@lists.sourceforge.net>
Cc: Avi Kivity <avik@qumranet.com>
Subject: Re: windows acpi time drift
Date: Wed, 19 Mar 2008 01:33:43 +0200	[thread overview]
Message-ID: <1205883223.21936.42.camel@localhost.localdomain> (raw)
In-Reply-To: <1205881756.21936.21.camel@localhost.localdomain>


On Wed, 2008-03-19 at 01:09 +0200, Dor Laor wrote:
> After some research of time drift while using window windows acpi hal I
> discovered it uses the ... rtc timer as a source clock. 
> Not the apic, acpi nor the pit. The acpi timer is not used by the time
> keeping clock, the apic & pit timer irqs are masked.
> 
> In order to fix the time drift we need to fix the rtc emulation.
> The problem is that like the pit and the apic timers in userspace, the
> rtc also has inaccurate timer, thus leading to irq coalescing before
> getting acknowledged by the guest interrupt controller.
> 
> We have two options:
> 1. Bring another device to the kernel
> 	- It's a simple device
> 	- It will make the rtc clock more accurate (hrtimer)
> 	- Easy time drift fix like apic/pic
> 	- It has very minor performance improvment of canceling the 
>           need to go to userspace after vmexit, thus not syncing vmcs.
>           But it's only 15msec * 2 rate.

Hmm, when doing multimedia, windows increases the frequency of rtc from
64HZ to 1024HZ, thus in-kernel device will save 2048 user-space exits.
This might be a real improvement - small but measurable.

> 	but
> 	- both the pit & rtc are somehow code duplications from 
>           userspace. Both need more accurate timer + interface to 
>           detect irq acks by the pic/apic.
> 2. The other option is to have an accurate userspace timer (userspace
> hrtimer exist >= 2.6.24) and to add interface to pic/apic to queue
> pending irqs by the pit/rtc.
> The pending queue can be a simple atomic counter per irq.
> Note that we also need support for older host kernels.
> 
> Before implementing yet another in-kernel device I like to hear
> opinions. 
> Regards,
> Dor.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  reply	other threads:[~2008-03-18 23:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-18 23:09 windows acpi time drift Dor Laor
2008-03-18 23:33 ` Dor Laor [this message]
2008-03-18 23:57   ` Anthony Liguori
2008-03-18 23:35 ` Anthony Liguori
2008-03-19  8:19   ` Avi Kivity
2008-03-19 14:09     ` Anthony Liguori
2008-03-19 15:39       ` Avi Kivity
2008-03-19 16:27         ` Dor Laor
2008-03-19 17:45           ` Avi Kivity
2008-03-19  0:07 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1205883223.21936.42.camel@localhost.localdomain \
    --to=dor.laor@gmail.com \
    --cc=avik@qumranet.com \
    --cc=dor.laor@qumranet.com \
    --cc=kvm-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox