From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dor Laor <dor.laor@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] [RFC] Fix time drift of rtc
	clock +	general support
Date: Mon, 24 Mar 2008 00:40:59 +0200
Message-ID: <1206312059.30051.9.camel@localhost.localdomain>
References: <1206282453.18800.31.camel@localhost.localdomain>
	<200803231619.32472.paul@codesourcery.com>
Reply-To: dor.laor@qumranet.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
	qemu-devel@nongnu.org
To: Paul Brook <paul@codesourcery.com>
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
In-Reply-To: <200803231619.32472.paul@codesourcery.com>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org


On Sun, 2008-03-23 at 16:19 +0000, Paul Brook wrote:
> On Sunday 23 March 2008, Dor Laor wrote:
> > --- a/qemu/hw/irq.c
> > +++ b/qemu/hw/irq.c
> > @@ -30,6 +30,8 @@ struct IRQState {
> >      int n;
> >  };
> >  
> > +uint32_t qemu_irq_acked[NR_IRQ_WORDS];
> 
> This is absolute rubbish. The whole point of the IRQ framework is that it 
> doesn't assume a single flat IRQ controller.
> 

Thanks for the compliments & the review ...
I specifically said that I'll move this variable into per-cpu var.

Moreover, the translation between irq line to vector is handled by the
'qemu_get_irq_vector' that calls 'irq_controller_get_vector' should take
care of the translation.
It works for ioapic, I'm not sure if it works for the flat pic case yet.

Anyway you're welcome to drift without the patch or provide constructive
comments.

> Paul


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/