public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Jerone Young <jyoung5@us.ibm.com>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm-ppc-devel@lists.sourceforge.net, kvm-devel@lists.sourceforge.net
Subject: Re: [kvm-ppc-devel] [PATCH] Add -Werror	to	libkvm	compile
Date: Tue, 25 Mar 2008 14:09:32 -0500	[thread overview]
Message-ID: <1206472172.12682.3.camel@thinkpadL> (raw)
In-Reply-To: <47E931A8.9030509@qumranet.com>

Yeah. This could "potentially" cause hell for users (non developers)
down the road. I'm just going to keep this patch in my queue for myself,
so no one will complain about warnings from my patches anymore. 

I think having a --developer flag to configure could work, but we would
then need separate file for including the CFLAG, this would just clutter
things more. 

On Tue, 2008-03-25 at 19:08 +0200, Avi Kivity wrote:
> Jerone Young wrote:
> > It does work with gcc 4.2.3 . Though no idea if gcc-4.3 & 4.4 would
> > workout. Though they should. I'll need to to compile them and give them
> > a try.
> >   
> 
> While I'm a fan of -Werror, I have to agree with Anthony it can cause no 
> end of pain to users if they have a slightly different configuration.
> 
> Maybe enable it conditionally based on ./configure --developer as 
> Anthony suggests (but I'll forget to use it myself, I'm sure).
> 


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

  reply	other threads:[~2008-03-25 19:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-24 18:44 [PATCH] Add -Werror to libkvm compile Jerone Young
2008-03-24 19:42 ` [kvm-ppc-devel] " Segher Boessenkool
2008-03-25 16:33   ` Jerone Young
2008-03-25 17:08     ` Avi Kivity
2008-03-25 19:09       ` Jerone Young [this message]
2008-03-26 16:41         ` Avi Kivity
2008-03-24 20:28 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1206472172.12682.3.camel@thinkpadL \
    --to=jyoung5@us.ibm.com \
    --cc=avi@qumranet.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=kvm-ppc-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox