From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerone Young Subject: Re: [kvm-ppc-devel] [PATCH] Add -Werror to libkvm compile Date: Tue, 25 Mar 2008 14:09:32 -0500 Message-ID: <1206472172.12682.3.camel@thinkpadL> References: <92ec769968b9bf27d3489e819bf1bbf8@kernel.crashing.org> <1206462789.7284.1.camel@thinkpadL> <47E931A8.9030509@qumranet.com> Reply-To: jyoung5@us.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-ppc-devel@lists.sourceforge.net, kvm-devel@lists.sourceforge.net To: Avi Kivity Return-path: In-Reply-To: <47E931A8.9030509@qumranet.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Yeah. This could "potentially" cause hell for users (non developers) down the road. I'm just going to keep this patch in my queue for myself, so no one will complain about warnings from my patches anymore. I think having a --developer flag to configure could work, but we would then need separate file for including the CFLAG, this would just clutter things more. On Tue, 2008-03-25 at 19:08 +0200, Avi Kivity wrote: > Jerone Young wrote: > > It does work with gcc 4.2.3 . Though no idea if gcc-4.3 & 4.4 would > > workout. Though they should. I'll need to to compile them and give them > > a try. > > > > While I'm a fan of -Werror, I have to agree with Anthony it can cause no > end of pain to users if they have a slightly different configuration. > > Maybe enable it conditionally based on ./configure --developer as > Anthony suggests (but I'll forget to use it myself, I'm sure). > ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/