From: tgingold@free.fr
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: Avi Kivity <avi@qumranet.com>, "Luck, Tony" <tony.luck@intel.com>,
"Xu, Anthony" <anthony.xu@intel.com>, Jes Sorensen <jes@sgi.com>,
Akio Takebe <takebe_akio@jp.fujitsu.com>,
kvm-devel@lists.sourceforge.net,
kvm-ia64-devel@lists.sourceforge.net, linux-ia64@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Carsten Otte <cotte@de.ibm.com>
Subject: Re: [kvm-ia64-devel] [09/17] [PATCH] kvm/ia64: Add mmio decoder for kvm/ia64.
Date: Sun, 30 Mar 2008 16:34:30 +0200 [thread overview]
Message-ID: <1206887670.47efa4f6290f8@imp.free.fr> (raw)
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDCFF7EF7@pdsmsx415.ccr.corp.intel.com>
Hi,
Selon "Zhang, Xiantao" <xiantao.zhang@intel.com>:
> >From 5f82ea88c095cf89cbae920944c05e578f35365f Mon Sep 17 00:00:00 2001
> From: Xiantao Zhang <xiantao.zhang@intel.com>
> Date: Wed, 12 Mar 2008 14:48:09 +0800
> Subject: [PATCH] kvm/ia64: Add mmio decoder for kvm/ia64.
[...]
> + post_update = (inst.M5.i << 7) + inst.M5.imm7;
> + if (inst.M5.s)
> + temp -= post_update;
> + else
> + temp += post_update;
The sign extension is not done correctly here. (This has been fixed in Xen
code).
> + post_update = (inst.M3.i << 7) + inst.M3.imm7;
> + if (inst.M3.s)
> + temp -= post_update;
> + else
> + temp += post_update;
Ditto.
> + post_update = (inst.M10.i << 7) + inst.M10.imm7;
> + if (inst.M10.s)
> + temp -= post_update;
> + else
> + temp += post_update;
Ditto.
> + post_update = (inst.M10.i << 7) + inst.M10.imm7;
> + if (inst.M10.s)
> + temp -= post_update;
> + else
> + temp += post_update;
Ditto.
> + post_update = (inst.M15.i << 7) + inst.M15.imm7;
> + if (inst.M15.s)
> + temp -= post_update;
> + else
> + temp += post_update;
Ditto.
Tristan.
next prev parent reply other threads:[~2008-03-30 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 9:58 [09/17] [PATCH] kvm/ia64: Add mmio decoder for kvm/ia64 Zhang, Xiantao
2008-03-30 14:34 ` tgingold [this message]
2008-03-31 7:57 ` [kvm-ia64-devel] " Zhang, Xiantao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1206887670.47efa4f6290f8@imp.free.fr \
--to=tgingold@free.fr \
--cc=anthony.xu@intel.com \
--cc=avi@qumranet.com \
--cc=cotte@de.ibm.com \
--cc=jes@sgi.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=kvm-ia64-devel@lists.sourceforge.net \
--cc=linux-ia64@vger.kernel.org \
--cc=takebe_akio@jp.fujitsu.com \
--cc=tony.luck@intel.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox