From: Dor Laor <dor.laor@qumranet.com>
To: Amit Shah <amit.shah@qumranet.com>
Cc: chrisw@redhat.com, kvm-devel@lists.sourceforge.net,
allen.m.kay@intel.com, avi@qumranet.com, gcosta@redhat.com,
virtualization@lists.linux-foundation.org, BENAMI@il.ibm.com
Subject: Re: [PATCH 1/1] QEMU/KVM: Support for PCI Passthrough
Date: Sun, 13 Apr 2008 15:49:16 +0300 [thread overview]
Message-ID: <1208090956.17832.89.camel@localhost.localdomain> (raw)
In-Reply-To: <1207817334-31775-4-git-send-email-amit.shah@qumranet.com>
On Thu, 2008-04-10 at 11:48 +0300, Amit Shah wrote:
> We can assign a device from the host machine to a guest.
>
> A new command-line option, -pcidevice is added.
> For example, to invoke it for an Ethernet device sitting at
> PCI bus:dev.fn 04:08.0 with host IRQ 18, use this:
>
> -pcidevice Ethernet/04:08.0-18
>
> The host ethernet driver is to be removed before doing the passthrough.
>
> If kvm uses the in-kernel irqchip, interrupts are routed to
> the guest via the kvm module (accompanied kernel changes are necessar).
> If -no-kvm-irqchip is used, the 'irqhook' module, also included here,
> is to be used.
>
IMO we can drop the pci pass through support in userspace and only keep
the in-kenel chip path. Normally we do want the option of running w/o
kernel devices but it's only to test for regressions against userspace.
In this case it's all new code so there is no point to compare, it's
just lots of complicated code (userspace apic, irqhook module) that only
helpful for qemu. Since it's not likely qemu will merge it, let's stick
with the main path.
Comments?
Dor
> Signed-off-by: Amit Shah <amit.shah@qumranet.com>
> ---
> Makefile | 10 +-
> irqhook/Kbuild | 3 +
> irqhook/Makefile | 25 ++
> irqhook/irqhook_main.c | 215 ++++++++++++++
> kernel/Makefile | 4 +
> libkvm/libkvm-x86.c | 14 +-
> libkvm/libkvm.h | 24 ++
> qemu/Makefile.target | 1 +
> qemu/hw/apic.c | 2 +
> qemu/hw/isa.h | 2 +
> qemu/hw/pc.c | 4 +
> qemu/hw/pci-passthrough.c | 677 +++++++++++++++++++++++++++++++++++++++++++++
> qemu/hw/pci-passthrough.h | 102 +++++++
> qemu/hw/pci.c | 11 +
> qemu/hw/pci.h | 1 +
> qemu/hw/piix_pci.c | 19 ++
> qemu/vl.c | 16 +
> tools/pci_barsize.c | 53 ++++
> tools/pci_mmio.c | 82 ++++++
> 19 files changed, 1260 insertions(+), 5 deletions(-)
>
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
next prev parent reply other threads:[~2008-04-13 12:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 8:48 PCI Passthrough support for KVM Amit Shah
2008-04-10 8:48 ` [PATCH 1/2] KVM: Expose get_eoi_gsi() for IRQ acking by PCI passthrough devices Amit Shah
2008-04-10 8:48 ` [PATCH 2/2] KVM: Handle interrupts for " Amit Shah
2008-04-10 8:48 ` [PATCH 1/1] QEMU/KVM: Support for PCI Passthrough Amit Shah
2008-04-13 12:49 ` Dor Laor [this message]
2008-04-14 0:31 ` Samuel Masham
2008-04-18 5:39 ` Amit Shah
2008-04-18 8:46 ` [kvm-devel] " Samuel Masham
2008-04-13 8:36 ` [PATCH 2/2] KVM: Handle interrupts for PCI passthrough devices Avi Kivity
2008-04-22 17:28 ` Amit Shah
2008-05-02 10:35 ` Avi Kivity
2008-05-02 13:05 ` Amit Shah
2008-05-02 13:16 ` Avi Kivity
2008-04-13 8:22 ` [PATCH 1/2] KVM: Expose get_eoi_gsi() for IRQ acking by " Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1208090956.17832.89.camel@localhost.localdomain \
--to=dor.laor@qumranet.com \
--cc=BENAMI@il.ibm.com \
--cc=allen.m.kay@intel.com \
--cc=amit.shah@qumranet.com \
--cc=avi@qumranet.com \
--cc=chrisw@redhat.com \
--cc=gcosta@redhat.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox