Re: [PATCH 0/3] kvm-guest-drivers-linux: Fix GSO/partial csum support on older kernels

Avi Kivity
2008-06-20T18:43:36Z

Mark McLoughlin wrote:
> Hi,
> Here's a few patches to fix virtio_net GSO
> and partial csum support under older kernels.
>
>

Applied all, thanks. Sorry for the virtio-like latency in processing.

I don't much like the intense hackery involved in this. The way I think
it could be done is:

- hack virtio to use an API which is specific to kvm, but matches the
current upstream API:

s/net_func/virtio_compat_net_func/

including data structures.

- define this API on top of the host kernel's real API. For a recent
enough kernel, that's a one-to-one mapping:

virtio_compat_net_func() { return net_func(); }

for older ones there's a more trickery involved.

For kvm, this is a fairly successful strategy, but I imagine that for
virtio-net this will be much, much, more difficult.

- write Documentation/stable_api_nonsense_nonsense.txt.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.