From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: Re: [PATCH] Initialize kvm qemu enviroment breakpoints for PowerPC Date: Mon, 09 Jun 2008 09:54:42 -0500 Message-ID: <1213023282.3358.2.camel@localhost.localdomain> References: <600753fabc8b38e54129.1213021421@thinkpadL> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org To: Jerone Young Return-path: Received: from e2.ny.us.ibm.com ([32.97.182.142]:60228 "EHLO e2.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751958AbYFIOyr (ORCPT ); Mon, 9 Jun 2008 10:54:47 -0400 In-Reply-To: <600753fabc8b38e54129.1213021421@thinkpadL> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 2008-06-09 at 09:23 -0500, Jerone Young wrote: > diff --git a/qemu/gdbstub.c b/qemu/gdbstub.c > --- a/qemu/gdbstub.c > +++ b/qemu/gdbstub.c > @@ -983,6 +983,7 @@ static int gdb_handle_packet(GDBState *s > kvm_load_registers(env); > #elif defined (TARGET_PPC) > env->nip = addr; > + kvm_load_registers(env); > #elif defined (TARGET_SPARC) > env->pc = addr; > env->npc = addr + 4; > @@ -1021,6 +1022,7 @@ static int gdb_handle_packet(GDBState *s > kvm_load_registers(env); > #elif defined (TARGET_PPC) > env->nip = addr; > + kvm_load_registers(env); > #elif defined (TARGET_SPARC) > env->pc = addr; > env->npc = addr + 4; These should be protected by a kvm_enabled() test, just like you see for x86 four lines earlier. -- Hollis Blanchard IBM Linux Technology Center