From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerone Young Subject: Re: Latest qemu tcg breakage Date: Mon, 09 Jun 2008 11:55:39 -0500 Message-ID: <1213030539.6792.21.camel@thinkpadL> References: <1213019621.6792.7.camel@thinkpadL> <484D5BBF.6030904@codemonkey.ws> Reply-To: jyoung5@us.ibm.com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: kvm , kvm-ppc-devel To: Anthony Liguori Return-path: Received: from e35.co.us.ibm.com ([32.97.110.153]:44637 "EHLO e35.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752948AbYFIQzu (ORCPT ); Mon, 9 Jun 2008 12:55:50 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e35.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m59GtkFg017410 for ; Mon, 9 Jun 2008 12:55:46 -0400 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m59Gtdj7075658 for ; Mon, 9 Jun 2008 10:55:41 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m59Gtd8q004427 for ; Mon, 9 Jun 2008 10:55:39 -0600 In-Reply-To: <484D5BBF.6030904@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 2008-06-09 at 11:35 -0500, Anthony Liguori wrote: > Jerone Young wrote: > > So upstream qemu is being pervasive about changes with TCG, starting to > > place tcg only functions in exec.c . I've spun a quick patch that fixes > > things for PowerPC when building qemu. But we need to try and isolate > > TCG in upstream qemu as it is starting to leak, and I'm not sure of a > > good way to fix it as there is no CONFIG defined for tcg currently. > > > > Just something to keep in mind. > > > > Now that TCG supports PPC, shouldn't ya'll be able to drop > --disable-cpu-emulation. I believe that will simultaneously fix your > problem and reduce the difference between upstream QEMU. Hmm...this may just be what is needed. Building upstream CVS works. Actually building without --disable-cpu-emulation WORKS. So given this I'll create a patch to remove --disable-cpu-emulation and the fake cpu-exec files we have. > > Regards, > > Anthony Liguori > > > Signed-off-by: Jerone Young > > > > diff --git a/qemu/Makefile.target b/qemu/Makefile.target > > --- a/qemu/Makefile.target > > +++ b/qemu/Makefile.target > > @@ -196,7 +196,6 @@ LIBOBJS+=fake-exec.o > > LIBOBJS+=fake-exec.o > > else > > LIBOBJS+= translate-all.o translate.o > > -endif > > ifdef CONFIG_DYNGEN_OP > > LIBOBJS+=op.o > > endif > > @@ -205,6 +204,7 @@ CPPFLAGS+=-I$(SRC_PATH)/tcg -I$(SRC_PATH > > CPPFLAGS+=-I$(SRC_PATH)/tcg -I$(SRC_PATH)/tcg/$(ARCH) > > ifeq ($(ARCH),sparc64) > > CPPFLAGS+=-I$(SRC_PATH)/tcg/sparc > > +endif > > endif > > > > ifeq ($(USE_KVM), 1) > > diff --git a/qemu/exec.c b/qemu/exec.c > > --- a/qemu/exec.c > > +++ b/qemu/exec.c > > @@ -37,8 +37,11 @@ > > #include "exec-all.h" > > #include "qemu-common.h" > > > > +#ifdef USE_KVM > > +#include "qemu-kvm.h" > > +#else > > #include "tcg.h" > > -#include "qemu-kvm.h" > > +#endif > > > > #if defined(CONFIG_USER_ONLY) > > #include > > @@ -3197,7 +3200,9 @@ void dump_exec_info(FILE *f, > > cpu_fprintf(f, "TB flush count %d\n", tb_flush_count); > > cpu_fprintf(f, "TB invalidate count %d\n", > > tb_phys_invalidate_count); > > cpu_fprintf(f, "TLB flush count %d\n", tlb_flush_count); > > +#if !defined(USE_KVM) > > tcg_dump_info(f, cpu_fprintf); > > +#endif > > } > > > > #if !defined(CONFIG_USER_ONLY) > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe kvm" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > >