From: Jerone Young <jyoung5@us.ibm.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH 0 of 2] Remove --disable-cpu-emulation for qemu
Date: Fri, 13 Jun 2008 17:13:16 -0500 [thread overview]
Message-ID: <1213395196.7255.4.camel@thinkpadL> (raw)
In-Reply-To: <4852B1F8.1050802@codemonkey.ws>
I figured you would say that ;-) Seeing how Soren (so that's 2 votes) is
also fine with it, then let's just kick it to the crub and go ahead and
include the patch.
On Fri, 2008-06-13 at 12:44 -0500, Anthony Liguori wrote:
> Jerone Young wrote:
> > After getting some private emails on this patch. I felt that I needed to
> > say that these patches probably should not go in.
> >
>
> I agree with your sentiment, --disable-cpu-emulation is a terrible hack
> that's is only going to make things difficult to merge with upstream.
>
> The proper solution is to implement a -kvm target type much like
> -softmmu and -linux-user.
>
> So I think this patch series should go in.
>
> Regards,
>
> Anthony Liguori
>
> > There is some value in having a kvm only binary. So having the --disable
> > cpu-emulation flag still has value.
> >
> >
> > So best not to remove this honestly until everything completely merges
> > with upstream qemu.
> >
> > On Tue, 2008-06-10 at 13:50 -0500, Jerone Young wrote:
> >
> >> These patches remove all traces of --disable-cpu-emulation configuration flag.
> >>
> >> Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
> >>
> >> 6 files changed, 2 insertions(+), 227 deletions(-)
> >> qemu/Makefile.target | 6 --
> >> qemu/configure | 13 -----
> >> qemu/target-i386/fake-exec.c | 54 ---------------------
> >> qemu/target-ia64/fake-exec.c | 44 -----------------
> >> qemu/target-ppc/fake-exec.c | 104 ------------------------------------------
> >> qemu/vl.c | 8 ---
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe kvm" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >>
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe kvm" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-06-13 22:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-10 18:50 [PATCH 0 of 2] Remove --disable-cpu-emulation for qemu Jerone Young
2008-06-10 18:50 ` [PATCH 1 of 2] Remove qemu files and entries associated with --disable-cpu-emulation configure argument Jerone Young
2008-06-10 18:50 ` [PATCH 2 of 2] Create dyngen dependency for exec.o for those who still have dyngen Jerone Young
2008-06-13 15:31 ` [PATCH 0 of 2] Remove --disable-cpu-emulation for qemu Jerone Young
2008-06-13 17:44 ` Anthony Liguori
2008-06-13 18:01 ` Soren Hansen
2008-06-13 22:13 ` Jerone Young [this message]
2008-06-17 13:27 ` Anthony Liguori
2008-06-18 13:19 ` Avi Kivity
2008-06-18 13:20 ` Avi Kivity
2008-06-18 20:56 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213395196.7255.4.camel@thinkpadL \
--to=jyoung5@us.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox