From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dor Laor Subject: Re: [PATCH 1/4] KVM: Report hardware virtualization features Date: Sun, 22 Jun 2008 15:18:14 +0300 Message-ID: <1214137094.31471.182.camel@localhost.localdomain> References: <200806191842.56275.sheng.yang@intel.com> <485DF60F.4070907@qumranet.com> Reply-To: dor.laor@qumranet.com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "Yang, Sheng" , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from il.qumranet.com ([212.179.150.194]:32075 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751583AbYFVMTs (ORCPT ); Sun, 22 Jun 2008 08:19:48 -0400 In-Reply-To: <485DF60F.4070907@qumranet.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, 2008-06-22 at 09:49 +0300, Avi Kivity wrote: > Yang, Sheng wrote: > > From f02d2ccf01e8671d2da517f14a908d1df1cc42ad Mon Sep 17 00:00:00 2001 > > From: Sheng Yang > > Date: Thu, 19 Jun 2008 18:41:26 +0800 > > Subject: [PATCH] KVM: Report hardware virtualization features > > > > The hardware virtualization technology evolves very fast. But currently it's > > hard to tell if your CPU support certain kind of HW technology without dig > > into the source code. > > > > The patch introduced a virtual file called "kvm_hw_feature_report" under > > /sys/devices/system/kvm/kvm0 to show the mainly important current hardware > > virtualization feature, then it's pretty easy to tell if your CPU support > > some advanced virtualization technology now. > > > > > > Yes, this is definitely helpful. However, I think that users will > expect cpu flags under /proc/cpuinfo. > > Perhaps we should add a new line 'virt flags' to /proc/cpuinfo? I think > all the features are reported using msrs, so it can be done from > arch/x86/kernel/cpu/proc.c without involving kvm at all. > while I agree with Avi, it would be nice thought to see them on older kernels. At least sprinkle a printk message.