From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: Re: [PATCH] [v2] Remove use of bit fields in kvm trace structure Date: Wed, 25 Jun 2008 10:55:53 -0500 Message-ID: <1214409353.1746.5.camel@localhost.localdomain> References: <5ba8c03afeab340508e0.1214333686@thinkpadL> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, Jerone Young To: Avi Kivity Return-path: Received: from e5.ny.us.ibm.com ([32.97.182.145]:45414 "EHLO e5.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758AbYFYPzw (ORCPT ); Wed, 25 Jun 2008 11:55:52 -0400 In-Reply-To: <5ba8c03afeab340508e0.1214333686@thinkpadL> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 2008-06-24 at 13:54 -0500, Jerone Young wrote: > 2 files changed, 30 insertions(+), 11 deletions(-) > include/linux/kvm.h | 17 ++++++++++++++--- > virt/kvm/kvm_trace.c | 24 ++++++++++++++++-------- > > > *Updates: > Create global definitions for setting trace records as opposed to > explicitly setting them inside of a function. > > This patch fixes kvmtrace use on big endian systems. When using bit > fields the compiler will lay data out in the wrong order expected when > laid down into a file. This fixes it by using one variable instead of > using bit fields. > > Signed-off-by: Jerone Young Acked-by: Hollis Blanchard Avi, if this is OK now, please also apply Jerone's earlier patches: [PATCH 2 of 3] Move KVM TRACE DEFINITIONS to common header [PATCH 3 of 3] Add new KVM TRACE events (and add my Acked-by to those as well). -- Hollis Blanchard IBM Linux Technology Center