From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark McLoughlin <markmc@redhat.com>
Subject: Re: Freeze with KVM_CLOCK, undocumented dependency VIRTIO_BLK ->
	VIRTIO_PCI
Date: Thu, 03 Jul 2008 15:44:28 +0100
Message-ID: <1215096268.7524.1.camel@muff>
References: <g3j4n7$6b7$1@ger.gmane.org>  <485DBBCD.5060600@codemonkey.ws>
	 <1214993464.13909.7.camel@muff>  <486CDC42.3070803@qumranet.com>
Reply-To: Mark McLoughlin <markmc@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: Anthony Liguori <anthony@codemonkey.ws>,
	Bernhard Schmidt <berni@birkenwald.de>, kvm@vger.kernel.org
To: Avi Kivity <avi@qumranet.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([66.187.233.31]:51592 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752025AbYGCOpY (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 3 Jul 2008 10:45:24 -0400
In-Reply-To: <486CDC42.3070803@qumranet.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, 2008-07-03 at 17:03 +0300, Avi Kivity wrote:
> Mark McLoughlin wrote:

> >   2) Although we currently build virtio_pci as a module in Fedora, it 
> >      leads to a pretty strange situation where e.g. mkinitrd and 
> >      anaconda need to explicitly include the virtio_pci module; I 
> >      don't think there's analogous situation where bus probing logic is 
> >      in a module rather than built into the kernel
> >
> >   
> 
> Sounds like an mkinitrd bug.  When mkinitrd includes a module, it should 
> also include all of its dependencies.

It does ... but nothing requires virtio_pci ...

Cheers,
Mark.