From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Avi Kivity <avi@qumranet.com>, kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH 1/4] reduce kvm stack usage in kvm_arch_vm_ioctl()
Date: Mon, 28 Jul 2008 11:52:00 -0700 [thread overview]
Message-ID: <1217271120.23502.17.camel@nimitz> (raw)
In-Reply-To: <488E1416.9040000@us.ibm.com>
On Mon, 2008-07-28 at 13:46 -0500, Anthony Liguori wrote:
> Tricking gcc seems like a bad thing to me. Who knows what crazy thing
> GCC is going to do in the future.
>
> Why not just kmalloc() these things? Is kmalloc really that slow?
In this case, I the kmalloc() just looked worse. I think there were
more than 2 uses for each of those structures, and we would have needed
a kmalloc() for every use. Those ioctl()s are hard enough to read as it
is. :)
It wasn't for speed in this case, at least.
-- Dave
next prev parent reply other threads:[~2008-07-28 18:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-28 18:15 [PATCH 1/4] reduce kvm stack usage in kvm_arch_vm_ioctl() Dave Hansen
2008-07-28 18:46 ` Anthony Liguori
2008-07-28 18:52 ` Dave Hansen [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-08-04 18:31 Dave Hansen
2008-08-11 9:29 ` Avi Kivity
2008-08-11 17:01 Dave Hansen
2008-08-12 13:00 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217271120.23502.17.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox