From: ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org
To: kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org,
avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org
Subject: [PATCH] kvm: fix kvm_para.h header dependency
Date: Tue, 29 Jul 2008 16:23:29 +0200 [thread overview]
Message-ID: <1217341409-755-1-git-send-email-ehrhardt@linux.vnet.ibm.com> (raw)
From: Christian Ehrhardt <ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
I currently work on paravirtual extensions for powerpc and found that the
current header dependencies create a classic "chicken or egg problem" leading
to the point that you can't use definitions out of kvm_host.h in kvm_para.h
I found it because I wanted to use kvm_vcpu, after looking around I found
that neither kvm_host.h nor any file including it today needs anything from
kvm_para.h.
C Files needing definitions of kvm_para.h should include it diretly anyway
instead of kvm_host.h and hoping for nice follow up includes in the header.
Compilation of the patch tested for x86, powerpc and s390 (thanks to Christian
Borntraeger).
Easy solution to allow e.g. kvm_vcpu in kvm_para.h, but I might overlook
something, comments welcome.
Signed-off-by: Christian Ehrhardt <ehrhardt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
---
[diffstat]
kvm_host.h | 1 -
1 file changed, 1 deletion(-)
[diff]
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index a18aaad..af29039 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -19,7 +19,6 @@
#include <asm/signal.h>
#include <linux/kvm.h>
-#include <linux/kvm_para.h>
#include <linux/kvm_types.h>
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
reply other threads:[~2008-07-29 14:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217341409-755-1-git-send-email-ehrhardt@linux.vnet.ibm.com \
--to=ehrhardt-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
--cc=hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox