Re: [PATCH] kvm: qemu: Handle tap fds with IFF_VNET_HDR

Avi Kivity
2008-08-20T17:27:59Z

Mark McLoughlin wrote:
> I would have included that link in the previous mail, but I see another
> one of my "patch appended" mails ended up being quoted fully in the
> commit message:
>
> http://git.kernel.org/?p=virt/kvm/kvm-userspace.git;a=commit;h=db424ac3052fe9392e3287b6d8cbfa9e9706cecd
>
> Other people seem to manage to avoid this, but trying it out myself with
> git-am the best I can come up with is to run "git-am -i" and edit the
> commit message, which sucks.
>
> Are others using some other mbox-to-git-commits script, I wonder?
>
>

No -- that was my error; I usually edit the commit messages before
committing.

In this particular case, there was no need to edit any of the patches
(except the updated one), which caused me to miss out. I'll keep a
better lookup next time.

Oh, and there's some trick with triple-dash. If you do

> log message
>
> ---
>
> junk
>
> patch

Then git-am will ignore junk and use just the log message. That's how
the diffstats escape.

--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.