From: Mark McLoughlin <markmc@redhat.com>
To: Mark Pulford <mark@kyne.com.au>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] Fix COMPAT_csum_offset #endif in virtio_net.c
Date: Wed, 10 Sep 2008 18:35:16 +0100 [thread overview]
Message-ID: <1221068116.31151.11.camel@blaa> (raw)
In-Reply-To: <20080825124235.GA27216@tolk.kyne.com.au>
On Mon, 2008-08-25 at 22:12 +0930, Mark Pulford wrote:
> Fix COMPAT_csum_offset #else/#endif block in virtio_net.c. The #endif
> was being output 1 line too early.
>
> Signed-off-by: Mark Pulford <mark@kyne.com.au>
>
> diff --git a/hack-module.awk b/hack-module.awk
> index a3275fa..7cb9381 100644
> --- a/hack-module.awk
> +++ b/hack-module.awk
> @@ -134,6 +134,9 @@
> print "\t\thdr->csum_start = skb->h.raw - skb->data;";
> print "\t\thdr->csum_offset = skb->csum;";
> print "#else"
> +}
> +
> +/hdr->csum_offset = skb->csum_offset/ {
> need_endif = 1;
> }
This looks right to me; I had a slightly uglier version that I forgot to
upstream.
Acked-by: Mark McLoughlin <markmc@redhat.com>
Cheers,
Mark.
next prev parent reply other threads:[~2008-09-10 17:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 12:42 [PATCH] Fix COMPAT_csum_offset #endif in virtio_net.c Mark Pulford
2008-08-25 12:45 ` Mark Pulford
2008-09-10 17:35 ` Mark McLoughlin [this message]
2008-09-13 5:05 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1221068116.31151.11.camel@blaa \
--to=markmc@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mark@kyne.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox