* [PATCH] Fix COMPAT_csum_offset #endif in virtio_net.c
@ 2008-08-25 12:42 Mark Pulford
2008-08-25 12:45 ` Mark Pulford
2008-09-10 17:35 ` Mark McLoughlin
0 siblings, 2 replies; 4+ messages in thread
From: Mark Pulford @ 2008-08-25 12:42 UTC (permalink / raw)
To: kvm
Fix COMPAT_csum_offset #else/#endif block in virtio_net.c. The #endif
was being output 1 line too early.
Signed-off-by: Mark Pulford <mark@kyne.com.au>
diff --git a/hack-module.awk b/hack-module.awk
index a3275fa..7cb9381 100644
--- a/hack-module.awk
+++ b/hack-module.awk
@@ -134,6 +134,9 @@
print "\t\thdr->csum_start = skb->h.raw - skb->data;";
print "\t\thdr->csum_offset = skb->csum;";
print "#else"
+}
+
+/hdr->csum_offset = skb->csum_offset/ {
need_endif = 1;
}
--
1.5.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Fix COMPAT_csum_offset #endif in virtio_net.c
2008-08-25 12:42 [PATCH] Fix COMPAT_csum_offset #endif in virtio_net.c Mark Pulford
@ 2008-08-25 12:45 ` Mark Pulford
2008-09-10 17:35 ` Mark McLoughlin
1 sibling, 0 replies; 4+ messages in thread
From: Mark Pulford @ 2008-08-25 12:45 UTC (permalink / raw)
To: kvm
Hi,
On Mon, Aug 25, 2008 at 10:12:35PM +0930, Mark Pulford wrote:
> Fix COMPAT_csum_offset #else/#endif block in virtio_net.c. The #endif
> was being output 1 line too early.
This patch was required to build a working virtio_net driver under
2.6.18.
Regards,
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix COMPAT_csum_offset #endif in virtio_net.c
2008-08-25 12:42 [PATCH] Fix COMPAT_csum_offset #endif in virtio_net.c Mark Pulford
2008-08-25 12:45 ` Mark Pulford
@ 2008-09-10 17:35 ` Mark McLoughlin
2008-09-13 5:05 ` Avi Kivity
1 sibling, 1 reply; 4+ messages in thread
From: Mark McLoughlin @ 2008-09-10 17:35 UTC (permalink / raw)
To: Mark Pulford; +Cc: kvm
On Mon, 2008-08-25 at 22:12 +0930, Mark Pulford wrote:
> Fix COMPAT_csum_offset #else/#endif block in virtio_net.c. The #endif
> was being output 1 line too early.
>
> Signed-off-by: Mark Pulford <mark@kyne.com.au>
>
> diff --git a/hack-module.awk b/hack-module.awk
> index a3275fa..7cb9381 100644
> --- a/hack-module.awk
> +++ b/hack-module.awk
> @@ -134,6 +134,9 @@
> print "\t\thdr->csum_start = skb->h.raw - skb->data;";
> print "\t\thdr->csum_offset = skb->csum;";
> print "#else"
> +}
> +
> +/hdr->csum_offset = skb->csum_offset/ {
> need_endif = 1;
> }
This looks right to me; I had a slightly uglier version that I forgot to
upstream.
Acked-by: Mark McLoughlin <markmc@redhat.com>
Cheers,
Mark.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Fix COMPAT_csum_offset #endif in virtio_net.c
2008-09-10 17:35 ` Mark McLoughlin
@ 2008-09-13 5:05 ` Avi Kivity
0 siblings, 0 replies; 4+ messages in thread
From: Avi Kivity @ 2008-09-13 5:05 UTC (permalink / raw)
To: Mark McLoughlin; +Cc: Mark Pulford, kvm
Mark McLoughlin wrote:
> On Mon, 2008-08-25 at 22:12 +0930, Mark Pulford wrote:
>
>> Fix COMPAT_csum_offset #else/#endif block in virtio_net.c. The #endif
>> was being output 1 line too early.
>>
>> Signed-off-by: Mark Pulford <mark@kyne.com.au>
>>
>> diff --git a/hack-module.awk b/hack-module.awk
>> index a3275fa..7cb9381 100644
>> --- a/hack-module.awk
>> +++ b/hack-module.awk
>> @@ -134,6 +134,9 @@
>> print "\t\thdr->csum_start = skb->h.raw - skb->data;";
>> print "\t\thdr->csum_offset = skb->csum;";
>> print "#else"
>> +}
>> +
>> +/hdr->csum_offset = skb->csum_offset/ {
>> need_endif = 1;
>> }
>>
>
> This looks right to me; I had a slightly uglier version that I forgot to
> upstream.
>
> Acked-by: Mark McLoughlin <markmc@redhat.com>
>
>
Thanks for the reminder; applied.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-09-13 5:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-25 12:42 [PATCH] Fix COMPAT_csum_offset #endif in virtio_net.c Mark Pulford
2008-08-25 12:45 ` Mark Pulford
2008-09-10 17:35 ` Mark McLoughlin
2008-09-13 5:05 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox