public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	"KVM list" <kvm@vger.kernel.org>
Subject: Re: [GIT PULL] KVM fixes for 4.10 merge window
Date: Sat, 17 Dec 2016 03:22:37 -0500 (EST)	[thread overview]
Message-ID: <1221273905.4447182.1481962957478.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CA+55aFxwwz2pcBH0U=7QK+MEQdxxMuYw5h0JEYvg8L1-V_gzBA@mail.gmail.com>


> On Fri, Dec 16, 2016 at 8:57 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> >   git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus
> 
> This piece-of-shit branch has obviously never been even compile-tested:
> 
>   arch/x86/kernel/kvm.c: In function ‘__kvm_vcpu_is_preempted’:
>   arch/x86/kernel/kvm.c:596:14: error: ‘struct kvm_steal_time’ has no
> member named ‘preempted’
> 
> where commit b94c3698b4b0 ("Revert "x86/kvm: Support the vCPU
> preemption check"") removed the "preempted" field from struct
> kvm_steal_time, but you left this in place:
> 
>   __visible bool __kvm_vcpu_is_preempted(int cpu)
>   {
>           struct kvm_steal_time *src = &per_cpu(steal_time, cpu);
> 
>           return !!src->preempted;
>   }
> 
> And no, that is not a merge artifact in my tree (although that
> function did come in from Ingo). That compile failure comes from your
> very own branch.

Yes, it does.  Well, to be honest I did test this (not just compile-test
it) but I didn't have KVM guest support turned on, only KVM host support.

Sorry, I'll resend it and make sure I do a "make allmodconfig" in the
future (and not send pull requests at 6 PM on Friday).

Paolo

      parent reply	other threads:[~2016-12-17  8:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-16 16:57 [GIT PULL] KVM fixes for 4.10 merge window Paolo Bonzini
2016-12-16 19:42 ` Linus Torvalds
2016-12-17  3:09   ` Pan Xinhui
2016-12-17  8:24     ` Paolo Bonzini
2016-12-17  8:22   ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1221273905.4447182.1481962957478.JavaMail.zimbra@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rkrcmar@redhat.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox