From mboxrd@z Thu Jan 1 00:00:00 1970 From: TJ Subject: Re: [Qemu-devel] Re: [PATCH] Add USB sys file-system support (v5) Date: Tue, 23 Sep 2008 02:23:12 +0100 Message-ID: <1222132992.18297.10.camel@hephaestion> References: <1220571341.2638.6.camel@hephaestion> <1220580385.2638.15.camel@hephaestion> <48C1346F.3000405@windriver.com> <1220640699.5470.15.camel@hephaestion> <48C1862C.3050307@windriver.com> <1220649226.9611.13.camel@hephaestion> <48C53B04.9030006@windriver.com> <1221679892.17792.6.camel@hephaestion> <48D16904.30104@codemonkey.ws> <1221691647.17792.55.camel@hephaestion> <48D81E26.9080802@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: kvm To: qemu-devel@nongnu.org Return-path: Received: from tjworld.net ([67.18.187.6]:56356 "EHLO tjworld.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753573AbYIWBXP (ORCPT ); Mon, 22 Sep 2008 21:23:15 -0400 In-Reply-To: <48D81E26.9080802@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 2008-09-22 at 17:37 -0500, Anthony Liguori wrote: > This patch is still white spaced damaged. > Is identical to this chunk with the exception of whitespace. But > curiously, not enough white space to warrant such a large diff. I broke > out ediff-buffers to verify this. Did you reformat this whole region > and then just query-replace the tabs with spaces? I can't see how diff > would generate this chunk otherwise. > > There should be no changes here. I don't mean to be pedantic but it's > extremely difficult to review a patch like this. I suspect it is because I copy/pasted that code from its original location in usb_host_scan() to the new usb_host_scan_dev(), and subsequently did some shuffling about. Could it also be because that hunk has moved both location and containing function? I was trying to figure out in my head how diff would efficiently handle that but gave up :) It looks as if I need to recreate the new source version again manually, making sure the editor doesn't mess with tabs.