From: Avi Kivity <avi@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: kvm@vger.kernel.org, Avi Kivity <avi@qumranet.com>
Subject: [PATCH 24/40] KVM: VMX: Avoid vmwrite(HOST_RSP) when possible
Date: Tue, 23 Sep 2008 16:46:38 +0300 [thread overview]
Message-ID: <1222177614-26669-25-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1222177614-26669-1-git-send-email-avi@redhat.com>
From: Avi Kivity <avi@qumranet.com>
Usually HOST_RSP retains its value across guest entries. Take advantage
of this and avoid a vmwrite() when this is so.
Signed-off-by: Avi Kivity <avi@qumranet.com>
---
arch/x86/kvm/vmx.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index fc8996b..ddb49e3 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -58,6 +58,7 @@ struct vmcs {
struct vcpu_vmx {
struct kvm_vcpu vcpu;
struct list_head local_vcpus_link;
+ unsigned long host_rsp;
int launched;
u8 fail;
u32 idt_vectoring_info;
@@ -2982,7 +2983,11 @@ static void vmx_vcpu_run(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run)
/* Store host registers */
"push %%"R"dx; push %%"R"bp;"
"push %%"R"cx \n\t"
+ "cmp %%"R"sp, %c[host_rsp](%0) \n\t"
+ "je 1f \n\t"
+ "mov %%"R"sp, %c[host_rsp](%0) \n\t"
__ex(ASM_VMX_VMWRITE_RSP_RDX) "\n\t"
+ "1: \n\t"
/* Check if vmlaunch of vmresume is needed */
"cmpl $0, %c[launched](%0) \n\t"
/* Load guest registers. Don't clobber flags. */
@@ -3039,6 +3044,7 @@ static void vmx_vcpu_run(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run)
: : "c"(vmx), "d"((unsigned long)HOST_RSP),
[launched]"i"(offsetof(struct vcpu_vmx, launched)),
[fail]"i"(offsetof(struct vcpu_vmx, fail)),
+ [host_rsp]"i"(offsetof(struct vcpu_vmx, host_rsp)),
[rax]"i"(offsetof(struct vcpu_vmx, vcpu.arch.regs[VCPU_REGS_RAX])),
[rbx]"i"(offsetof(struct vcpu_vmx, vcpu.arch.regs[VCPU_REGS_RBX])),
[rcx]"i"(offsetof(struct vcpu_vmx, vcpu.arch.regs[VCPU_REGS_RCX])),
--
1.6.0.1
next prev parent reply other threads:[~2008-09-23 13:47 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-23 13:46 [PATCH 00/40] KVM Updates for 2.6.28 merge window (part 1 of 3) Avi Kivity
2008-09-23 13:46 ` [PATCH 01/40] KVM: VMX: Rename misnamed msr bits Avi Kivity
2008-09-23 13:46 ` [PATCH 02/40] KVM: x86: accessors for guest registers Avi Kivity
2008-09-23 13:46 ` [PATCH 03/40] KVM: Move KVM TRACE DEFINITIONS to common header Avi Kivity
2008-09-23 13:46 ` [PATCH 04/40] KVM: Introduce kvm_set_irq to inject interrupts in guests Avi Kivity
2008-09-23 13:46 ` [PATCH 05/40] KVM: MMU: Separate the code for unlinking a shadow page from its parents Avi Kivity
2008-09-23 13:46 ` [PATCH 06/40] KVM: MMU: Simplify kvm_mmu_zap_page() Avi Kivity
2008-09-23 13:46 ` [PATCH 07/40] KVM: Move NMI IRET fault processing to new vmx_complete_interrupts() Avi Kivity
2008-09-23 13:46 ` [PATCH 08/40] KVM: VMX: Move nmi injection failure processing to vm exit path Avi Kivity
2008-09-23 13:46 ` [PATCH 09/40] KVM: Clear exception queue before emulating an instruction Avi Kivity
2008-09-23 13:46 ` [PATCH 10/40] KVM: VMX: Fix pending exception processing Avi Kivity
2008-09-23 13:46 ` [PATCH 11/40] KVM: Add a pending interrupt queue Avi Kivity
2008-09-23 13:46 ` [PATCH 12/40] KVM: VMX: Move interrupt post-processing to vmx_complete_interrupts() Avi Kivity
2008-09-23 13:46 ` [PATCH 13/40] KVM: VMX: Remove redundant check in handle_rmode_exception Avi Kivity
2008-09-23 13:46 ` [PATCH 14/40] KVM: Consolidate PIC isr clearing into a function Avi Kivity
2008-09-23 13:46 ` [PATCH 15/40] KVM: Consolidate XX_VECTOR defines Avi Kivity
2008-09-23 13:46 ` [PATCH 16/40] KVM: VMX: Reinject real mode exception Avi Kivity
2008-09-23 13:46 ` [PATCH 17/40] KVM: VMX: Unify register save/restore across 32 and 64 bit hosts Avi Kivity
2008-09-23 13:46 ` [PATCH 18/40] KVM: SVM: " Avi Kivity
2008-09-23 13:46 ` [PATCH 19/40] KVM: kvmtrace: Remove use of bit fields in kvm trace structure Avi Kivity
2008-09-23 13:46 ` [PATCH 20/40] KVM: kvmtrace: replace get_cycles with ktime_get v3 Avi Kivity
2008-09-23 13:46 ` [PATCH 21/40] KVM: ppc: enable KVM_TRACE building for powerpc Avi Kivity
2008-09-23 13:46 ` [PATCH 22/40] KVM: ppc: adds trace points for ppc tlb activity Avi Kivity
2008-09-23 13:46 ` [PATCH 23/40] KVM: ppc: trace powerpc instruction emulation Avi Kivity
2008-09-23 13:46 ` Avi Kivity [this message]
2008-09-23 13:46 ` [PATCH 25/40] KVM: Ignore DEBUGCTL MSRs with no effect Avi Kivity
2008-09-23 13:46 ` [PATCH 26/40] KVM: ppc: guest breakpoint support Avi Kivity
2008-09-23 13:46 ` [PATCH 27/40] KVM: ppc: Stop saving host TLB state Avi Kivity
2008-09-23 13:46 ` [PATCH 28/40] KVM: ppc: Write only modified shadow entries into the TLB on exit Avi Kivity
2008-09-23 13:46 ` [PATCH 29/40] KVM: powerpc: Map guest userspace with TID=0 mappings Avi Kivity
2008-09-23 13:46 ` [PATCH 30/40] KVM: Add irq ack notifier list Avi Kivity
2008-09-23 13:46 ` [PATCH 31/40] KVM: irq ack notification Avi Kivity
2008-09-23 13:46 ` [PATCH 32/40] KVM: PIT: fix injection logic and count Avi Kivity
2008-09-23 13:46 ` [PATCH 33/40] x86: paravirt: factor out cpu_khz to common code Avi Kivity
2008-09-23 13:46 ` [PATCH 34/40] x86: KVM guest: use paravirt function to calculate cpu khz Avi Kivity
2008-09-23 13:46 ` [PATCH 35/40] KVM: direct mmio pfn check Avi Kivity
2008-09-23 13:46 ` [PATCH 36/40] KVM: pci device assignment Avi Kivity
2008-09-23 13:46 ` [PATCH 37/40] KVM: Reduce kvm stack usage in kvm_arch_vm_ioctl() Avi Kivity
2008-09-23 13:46 ` [PATCH 38/40] KVM: Reduce stack usage in kvm_vcpu_ioctl() Avi Kivity
2008-09-23 13:46 ` [PATCH 39/40] KVM: Reduce stack usage in kvm_arch_vcpu_ioctl() Avi Kivity
2008-09-23 13:46 ` [PATCH 40/40] KVM: Reduce stack usage in kvm_pv_mmu_op() Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222177614-26669-25-git-send-email-avi@redhat.com \
--to=avi@redhat.com \
--cc=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox