Re: [PATCH 2/3][RESEND] kvm-userspace: kvmppc: fix hostlonbits detection when cross compiling

Hollis Blanchard
2008-09-29T14:44:45Z

On Mon, 2008-09-29 at 14:50 +0200, ehrhardt@linux.vnet.ibm.com wrote:
> From: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
>
> The kvm merge with qemu brought code for 64bit power that broke cross
> compilation. The issue is caused by configure trying to execute target
> architecture binaries where configure is executed.
>
> I tried to change that detection so that it works with&without cross
> compilation with only a small change and especially without an addtional
> configure command line switch. Including the bits/wordsize.h header a platform
> usually can check its wordsize and by doing that configure can check the
> hostlongbits without executing the binary. Instead it now stops after
> preprocessing stage which resolved the __WORDSIZE constant and retrieves
> that value.
>
> I don't like that check style, but it is at least less broken than before.
> Comments and other approaches welcome.

This needs to be CCed to qemu-devel@nongnu.org and applied upstream.

I don't know if bits/wordsize.h is too Linux-specific (or if that even
matters in the configure script).

--
Hollis Blanchard
IBM Linux Technology Center