From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: Re: [PATCH 2/3][RESEND] kvm-userspace: kvmppc: fix hostlonbits detection when cross compiling Date: Mon, 29 Sep 2008 09:43:52 -0500 Message-ID: <1222699432.11272.3.camel@localhost.localdomain> References: <1222692614-18532-1-git-send-email-ehrhardt@linux.vnet.ibm.com> <1222692614-18532-3-git-send-email-ehrhardt@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org To: ehrhardt@linux.vnet.ibm.com Return-path: Received: from e34.co.us.ibm.com ([32.97.110.152]:56658 "EHLO e34.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751478AbYI2Oop (ORCPT ); Mon, 29 Sep 2008 10:44:45 -0400 In-Reply-To: <1222692614-18532-3-git-send-email-ehrhardt@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 2008-09-29 at 14:50 +0200, ehrhardt@linux.vnet.ibm.com wrote: > From: Christian Ehrhardt > > The kvm merge with qemu brought code for 64bit power that broke cross > compilation. The issue is caused by configure trying to execute target > architecture binaries where configure is executed. > > I tried to change that detection so that it works with&without cross > compilation with only a small change and especially without an addtional > configure command line switch. Including the bits/wordsize.h header a platform > usually can check its wordsize and by doing that configure can check the > hostlongbits without executing the binary. Instead it now stops after > preprocessing stage which resolved the __WORDSIZE constant and retrieves > that value. > > I don't like that check style, but it is at least less broken than before. > Comments and other approaches welcome. This needs to be CCed to qemu-devel@nongnu.org and applied upstream. I don't know if bits/wordsize.h is too Linux-specific (or if that even matters in the configure script). -- Hollis Blanchard IBM Linux Technology Center