* [PATCH] kvmppc: comply with requirement for kvm_arch_try_push_nmi
@ 2008-10-17 8:46 ehrhardt
2008-10-17 14:47 ` Hollis Blanchard
2008-10-19 10:09 ` Avi Kivity
0 siblings, 2 replies; 3+ messages in thread
From: ehrhardt @ 2008-10-17 8:46 UTC (permalink / raw)
To: kvm-ppc, kvm, avi; +Cc: hollisb, ehrhardt
From: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
Since a recent patch all architetcures need a kvm_arch_try_push_nmi function.
Powerpc has no direct nmi equivalent, so this patch fixes only build for
powerpc by adding an empty stub.
If powerpc later wants to support the nmi monitor command somehow the function
can still be extended.
Signed-off-by: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
---
[diffstat]
qemu-kvm-powerpc.c | 8 ++++++++
1 file changed, 8 insertions(+)
[diff]
diff --git a/qemu/qemu-kvm-powerpc.c b/qemu/qemu-kvm-powerpc.c
--- a/qemu/qemu-kvm-powerpc.c
+++ b/qemu/qemu-kvm-powerpc.c
@@ -190,6 +190,14 @@
return 0;
}
+int kvm_arch_try_push_nmi(void *opaque)
+{
+ /* no nmi irq, so discard that call for now and return success.
+ * This might later get mapped to something on powerpc too if we want
+ * to support the nmi monitor command somwhow */
+ return 0;
+}
+
void kvm_arch_update_regs_for_sipi(CPUState *env)
{
printf("%s: no kvm-powerpc multi processor support yet!\n", __func__);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kvmppc: comply with requirement for kvm_arch_try_push_nmi
2008-10-17 8:46 [PATCH] kvmppc: comply with requirement for kvm_arch_try_push_nmi ehrhardt
@ 2008-10-17 14:47 ` Hollis Blanchard
2008-10-19 10:09 ` Avi Kivity
1 sibling, 0 replies; 3+ messages in thread
From: Hollis Blanchard @ 2008-10-17 14:47 UTC (permalink / raw)
To: Avi Kivity; +Cc: kvm-ppc, kvm
On Fri, 2008-10-17 at 10:46 +0200, ehrhardt@linux.vnet.ibm.com wrote:
> From: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
>
> Since a recent patch all architetcures need a kvm_arch_try_push_nmi function.
> Powerpc has no direct nmi equivalent, so this patch fixes only build for
> powerpc by adding an empty stub.
> If powerpc later wants to support the nmi monitor command somehow the function
> can still be extended.
>
> Signed-off-by: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
Acked-by: Hollis Blanchard <hollisb@us.ibm.com>
--
Hollis Blanchard
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kvmppc: comply with requirement for kvm_arch_try_push_nmi
2008-10-17 8:46 [PATCH] kvmppc: comply with requirement for kvm_arch_try_push_nmi ehrhardt
2008-10-17 14:47 ` Hollis Blanchard
@ 2008-10-19 10:09 ` Avi Kivity
1 sibling, 0 replies; 3+ messages in thread
From: Avi Kivity @ 2008-10-19 10:09 UTC (permalink / raw)
To: ehrhardt; +Cc: kvm-ppc, kvm, avi, hollisb
ehrhardt@linux.vnet.ibm.com wrote:
> From: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
>
> Since a recent patch all architetcures need a kvm_arch_try_push_nmi function.
> Powerpc has no direct nmi equivalent, so this patch fixes only build for
> powerpc by adding an empty stub.
> If powerpc later wants to support the nmi monitor command somehow the function
> can still be extended.
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-19 10:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-17 8:46 [PATCH] kvmppc: comply with requirement for kvm_arch_try_push_nmi ehrhardt
2008-10-17 14:47 ` Hollis Blanchard
2008-10-19 10:09 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox