From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark McLoughlin <markmc@redhat.com>
Subject: Re: [PATCH 5/6] device assignment: support for assigning PCI
	devices to guests
Date: Wed, 29 Oct 2008 11:15:10 +0000
Message-ID: <1225278910.7615.5.camel@blaa>
References: <1225188410-2222-1-git-send-email-muli@il.ibm.com>
	 <1225188410-2222-2-git-send-email-muli@il.ibm.com>
	 <1225188410-2222-3-git-send-email-muli@il.ibm.com>
	 <1225188410-2222-4-git-send-email-muli@il.ibm.com>
	 <1225188410-2222-5-git-send-email-muli@il.ibm.com>
	 <1225188410-2222-6-git-send-email-muli@il.ibm.com>
	 <1225212922.11515.85.camel@blaa>  <20081029103102.GQ6737@il.ibm.com>
Reply-To: Mark McLoughlin <markmc@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: avi@redhat.com, kvm@vger.kernel.org, anthony@codemonkey.ws,
	weidong.han@intel.com, Ben-Ami Yassour1 <BENAMI@il.ibm.com>,
	amit.shah@redhat.com, allen.m.kay@intel.com
To: Muli Ben-Yehuda <muli@il.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:58356 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752224AbYJ2LRO (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 29 Oct 2008 07:17:14 -0400
In-Reply-To: <20081029103102.GQ6737@il.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, 2008-10-29 at 12:31 +0200, Muli Ben-Yehuda wrote:
> On Tue, Oct 28, 2008 at 04:55:22PM +0000, Mark McLoughlin wrote:

> > nr_assigned_devices isn't actually used anywhere.
> 
> Nuked.

Still there.

> > > +#define MAX_IO_REGIONS (6)
> > 
> > Perhaps a comment to say this is the number of BARs in the config space
> > header?
> 
> Sure, comments are cheap.

You didn't add one though :-)

> > > +
> > > +    if (kvm_enabled() && device_assignment_enabled) {
> > 
> > The device_assignment_enabled flag looks like it shouldn't be needed.
> > 
> > If assigned_devices_index remains zero, nothing should happen
> > anyway.
> 
> Nuked.

Still there.

Cheers,
Mark.