public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Avi Kivity <avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Andrew Morton <akpm-3NddpPZAyC0@public.gmane.org>,
	Eduardo Habkost
	<ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Haren Myneni <hbabu-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>,
	Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
	"Eric W. Biederman"
	<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
	Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: [PATCH 0/6] kdump: disable virtualization extensions on crash (v2)
Date: Thu, 30 Oct 2008 11:34:40 -0200	[thread overview]
Message-ID: <1225373687-6960-1-git-send-email-ehabkost@redhat.com> (raw)


Hi,

After some discussion, this is my second try to fix properly the kdump
hang when the kvm-intel module is loaded. I've kept the virtualization
code inside the KVM, and just used a function pointer that can be
registered by KVM to be called at crash time.


This series is for one of the alternatives for solving the problem. Other
alternatives that were discussed were:

a) Using a raw notifier chain (kernel/notifier.c) (the first version
   of this series)
   - This was dropped because the less code we have to rely on, the better,
     and it would make it too easy to break kdump
b) Always calling vmxoff, after hacking the #UD vector to ignore
   unknown opcode exceptions.
  - Too hackish in my opinion. And we don't need to hack #UD, anyway,
    if we can simply test CR4.VMXE (all our code that run vmxon/vmxoff
    toggle CR4.VMXE accordingly)
c) Moving the equivalent to the hardware_disable()/hardware_enable() API
   (and the vmx and svm implementations) from the KVM module to the kernel
   core, so the kernel core knows which CPUs have virtualization enabled,
   and disables virtualization without calling into the KVM module.
   - This wasn't completely discarded, but would move to the core a bunch
     of code that always lived in the KVM module.

-- 
Eduardo

             reply	other threads:[~2008-10-30 13:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30 13:34 Eduardo Habkost [this message]
     [not found] ` <1225373687-6960-1-git-send-email-ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-10-30 13:34   ` [PATCH 1/6] kdump: crash-time virt disable function Eduardo Habkost
     [not found]     ` <1225373687-6960-2-git-send-email-ehabkost-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-10-30 13:50       ` Avi Kivity
     [not found]         ` <4909BBA7.1020307-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2008-10-30 16:24           ` Eduardo Habkost
2008-10-30 13:34   ` [PATCH 2/6] kvm_x86_ops: crash_hardware_disable() operation Eduardo Habkost
2008-10-30 13:34   ` [PATCH 3/6] kvm: svm: set crash_hardware_disable to svm_hardware_disable Eduardo Habkost
2008-10-30 13:34   ` [PATCH 4/6] kvm: vmx: crash_hardware_disable function Eduardo Habkost
2008-10-30 13:34   ` [PATCH 5/6] kvmx: x86: set kvm_x86_ops earlier on kvm_arch_init() Eduardo Habkost
2008-10-30 13:34   ` [PATCH 6/6] kvm: x86: set kdump virt_disable function on initialization Eduardo Habkost
2008-10-30 13:52   ` [PATCH 0/6] kdump: disable virtualization extensions on crash (v2) Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1225373687-6960-1-git-send-email-ehabkost@redhat.com \
    --to=ehabkost-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=akpm-3NddpPZAyC0@public.gmane.org \
    --cc=avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=hbabu-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
    --cc=kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox