From: Sheng Yang <sheng@linux.intel.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org, Sheng Yang <sheng@linux.intel.com>
Subject: [PATCH 01/10] KVM: Move ack notifier register and IRQ sourcd ID request
Date: Fri, 31 Oct 2008 12:50:38 +0800 [thread overview]
Message-ID: <1225428647-27614-2-git-send-email-sheng@linux.intel.com> (raw)
In-Reply-To: <1225428647-27614-1-git-send-email-sheng@linux.intel.com>
Signed-off-by: Sheng Yang <sheng@linux.intel.com>
---
virt/kvm/kvm_main.c | 30 +++++++++++++++++++-----------
1 files changed, 19 insertions(+), 11 deletions(-)
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 4f43abe..4647a7b 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -190,16 +190,31 @@ static int kvm_vm_ioctl_assign_irq(struct kvm *kvm,
return -EINVAL;
}
- if (match->irq_requested) {
+ if (!match->irq_requested) {
+ INIT_WORK(&match->interrupt_work,
+ kvm_assigned_dev_interrupt_work_handler);
+ if (irqchip_in_kernel(kvm)) {
+ /* Register ack nofitier */
+ match->ack_notifier.gsi = -1;
+ match->ack_notifier.irq_acked =
+ kvm_assigned_dev_ack_irq;
+ kvm_register_irq_ack_notifier(kvm,
+ &match->ack_notifier);
+
+ /* Request IRQ source ID */
+ r = kvm_request_irq_source_id(kvm);
+ if (r < 0)
+ goto out_release;
+ else
+ match->irq_source_id = r;
+ }
+ } else {
match->guest_irq = assigned_irq->guest_irq;
match->ack_notifier.gsi = assigned_irq->guest_irq;
mutex_unlock(&kvm->lock);
return 0;
}
- INIT_WORK(&match->interrupt_work,
- kvm_assigned_dev_interrupt_work_handler);
-
if (irqchip_in_kernel(kvm)) {
if (!capable(CAP_SYS_RAWIO)) {
r = -EPERM;
@@ -212,13 +227,6 @@ static int kvm_vm_ioctl_assign_irq(struct kvm *kvm,
match->host_irq = match->dev->irq;
match->guest_irq = assigned_irq->guest_irq;
match->ack_notifier.gsi = assigned_irq->guest_irq;
- match->ack_notifier.irq_acked = kvm_assigned_dev_ack_irq;
- kvm_register_irq_ack_notifier(kvm, &match->ack_notifier);
- r = kvm_request_irq_source_id(kvm);
- if (r < 0)
- goto out_release;
- else
- match->irq_source_id = r;
/* Even though this is PCI, we don't want to use shared
* interrupts. Sharing host devices with guest-assigned devices
--
1.5.4.5
next prev parent reply other threads:[~2008-10-31 4:53 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 4:50 [PATCH 0/10][v4] Enable MSI for KVM assigned device kernel part Sheng Yang
2008-10-31 4:50 ` Sheng Yang [this message]
2008-10-31 4:50 ` [PATCH 02/10] KVM: Separate update irq to a single function Sheng Yang
2008-10-31 4:50 ` [PATCH 03/10] KVM: Replace irq_requested with more generic irq_requested_type Sheng Yang
2008-10-31 4:50 ` [PATCH 04/10] KVM: Clean up assigned_device_update_irq Sheng Yang
2008-10-31 4:50 ` [PATCH 05/10] KVM: Add fields for MSI device assignment Sheng Yang
2008-11-04 11:05 ` Avi Kivity
2008-10-31 4:50 ` [PATCH 06/10] KVM: Export ioapic_get_delivery_bitmask Sheng Yang
2008-11-04 11:07 ` Avi Kivity
2008-11-04 11:09 ` Sheng Yang
2008-10-31 4:50 ` [PATCH 07/10] x86: Add MSI delivery mode value Sheng Yang
2008-11-04 11:09 ` Avi Kivity
2008-11-04 11:37 ` Sheng Yang
2008-10-31 4:50 ` [PATCH 08/10] KVM: Add assigned_device_msi_dispatch() Sheng Yang
2008-11-04 11:17 ` Avi Kivity
2008-11-04 11:17 ` Sheng Yang
2008-10-31 4:50 ` [PATCH 09/10] KVM: Enable MSI for device assignment Sheng Yang
2008-11-04 11:23 ` Avi Kivity
2008-11-04 13:25 ` Sheng Yang
2008-11-04 13:32 ` Avi Kivity
2008-11-04 13:58 ` Sheng Yang
2008-11-04 14:35 ` Avi Kivity
2008-11-04 14:57 ` Sheng Yang
2008-11-04 15:01 ` Avi Kivity
2008-11-04 15:14 ` Sheng Yang
2008-10-31 4:50 ` [PATCH 10/10] KVM: MSI to INTx translate Sheng Yang
2008-11-04 11:25 ` Avi Kivity
2008-11-04 11:40 ` Sheng Yang
2008-11-04 11:57 ` Avi Kivity
2008-11-04 12:55 ` Sheng Yang
-- strict thread matches above, loose matches on Subject: below --
2008-10-30 8:20 [RFC][PATCH 0/10][v3] Enable MSI for KVM assigned device Sheng Yang
2008-10-30 8:20 ` [PATCH 01/10] KVM: Move ack notifier register and IRQ sourcd ID request Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225428647-27614-2-git-send-email-sheng@linux.intel.com \
--to=sheng@linux.intel.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox