public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sheng Yang <sheng@linux.intel.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org, Sheng Yang <sheng@linux.intel.com>
Subject: [PATCH 03/10] KVM: Replace irq_requested with more generic irq_requested_type
Date: Fri, 31 Oct 2008 12:50:40 +0800	[thread overview]
Message-ID: <1225428647-27614-4-git-send-email-sheng@linux.intel.com> (raw)
In-Reply-To: <1225428647-27614-1-git-send-email-sheng@linux.intel.com>

Separate guest irq type and host irq type, for we can support guest using INTx
with host using MSI (but not opposite combination).

Signed-off-by: Sheng Yang <sheng@linux.intel.com>
---
 include/linux/kvm_host.h |    4 +++-
 virt/kvm/kvm_main.c      |    9 +++++----
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 3a0fb77..c3d4b96 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -307,7 +307,9 @@ struct kvm_assigned_dev_kernel {
 	int host_devfn;
 	int host_irq;
 	int guest_irq;
-	int irq_requested;
+#define KVM_ASSIGNED_DEV_GUEST_INTX	(1 << 0)
+#define KVM_ASSIGNED_DEV_HOST_INTX	(1 << 8)
+	unsigned long irq_requested_type;
 	int irq_source_id;
 	struct pci_dev *dev;
 	struct kvm *kvm;
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 7d261b1..ed1b243 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -140,7 +140,7 @@ static void kvm_free_assigned_device(struct kvm *kvm,
 				     struct kvm_assigned_dev_kernel
 				     *assigned_dev)
 {
-	if (irqchip_in_kernel(kvm) && assigned_dev->irq_requested)
+	if (irqchip_in_kernel(kvm) && assigned_dev->irq_requested_type)
 		free_irq(assigned_dev->host_irq, (void *)assigned_dev);
 
 	kvm_unregister_irq_ack_notifier(&assigned_dev->ack_notifier);
@@ -178,7 +178,7 @@ static int assigned_device_update_intx(struct kvm *kvm,
 			struct kvm_assigned_dev_kernel *adev,
 			struct kvm_assigned_irq *airq)
 {
-	if (adev->irq_requested) {
+	if (adev->irq_requested_type & KVM_ASSIGNED_DEV_GUEST_INTX) {
 		adev->guest_irq = airq->guest_irq;
 		adev->ack_notifier.gsi = airq->guest_irq;
 		return 0;
@@ -205,7 +205,8 @@ static int assigned_device_update_intx(struct kvm *kvm,
 			return -EIO;
 	}
 
-	adev->irq_requested = true;
+	adev->irq_requested_type = KVM_ASSIGNED_DEV_GUEST_INTX |
+				   KVM_ASSIGNED_DEV_HOST_INTX;
 	return 0;
 }
 
@@ -225,7 +226,7 @@ static int kvm_vm_ioctl_assign_irq(struct kvm *kvm,
 		return -EINVAL;
 	}
 
-	if (!match->irq_requested) {
+	if (!match->irq_requested_type) {
 		INIT_WORK(&match->interrupt_work,
 				kvm_assigned_dev_interrupt_work_handler);
 		if (irqchip_in_kernel(kvm)) {
-- 
1.5.4.5


  parent reply	other threads:[~2008-10-31  4:53 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-31  4:50 [PATCH 0/10][v4] Enable MSI for KVM assigned device kernel part Sheng Yang
2008-10-31  4:50 ` [PATCH 01/10] KVM: Move ack notifier register and IRQ sourcd ID request Sheng Yang
2008-10-31  4:50 ` [PATCH 02/10] KVM: Separate update irq to a single function Sheng Yang
2008-10-31  4:50 ` Sheng Yang [this message]
2008-10-31  4:50 ` [PATCH 04/10] KVM: Clean up assigned_device_update_irq Sheng Yang
2008-10-31  4:50 ` [PATCH 05/10] KVM: Add fields for MSI device assignment Sheng Yang
2008-11-04 11:05   ` Avi Kivity
2008-10-31  4:50 ` [PATCH 06/10] KVM: Export ioapic_get_delivery_bitmask Sheng Yang
2008-11-04 11:07   ` Avi Kivity
2008-11-04 11:09     ` Sheng Yang
2008-10-31  4:50 ` [PATCH 07/10] x86: Add MSI delivery mode value Sheng Yang
2008-11-04 11:09   ` Avi Kivity
2008-11-04 11:37     ` Sheng Yang
2008-10-31  4:50 ` [PATCH 08/10] KVM: Add assigned_device_msi_dispatch() Sheng Yang
2008-11-04 11:17   ` Avi Kivity
2008-11-04 11:17     ` Sheng Yang
2008-10-31  4:50 ` [PATCH 09/10] KVM: Enable MSI for device assignment Sheng Yang
2008-11-04 11:23   ` Avi Kivity
2008-11-04 13:25     ` Sheng Yang
2008-11-04 13:32       ` Avi Kivity
2008-11-04 13:58         ` Sheng Yang
2008-11-04 14:35           ` Avi Kivity
2008-11-04 14:57             ` Sheng Yang
2008-11-04 15:01               ` Avi Kivity
2008-11-04 15:14                 ` Sheng Yang
2008-10-31  4:50 ` [PATCH 10/10] KVM: MSI to INTx translate Sheng Yang
2008-11-04 11:25   ` Avi Kivity
2008-11-04 11:40     ` Sheng Yang
2008-11-04 11:57       ` Avi Kivity
2008-11-04 12:55         ` Sheng Yang
  -- strict thread matches above, loose matches on Subject: below --
2008-10-30  8:20 [RFC][PATCH 0/10][v3] Enable MSI for KVM assigned device Sheng Yang
2008-10-30  8:20 ` [PATCH 03/10] KVM: Replace irq_requested with more generic irq_requested_type Sheng Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1225428647-27614-4-git-send-email-sheng@linux.intel.com \
    --to=sheng@linux.intel.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox