From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: Re: large page size virtio issues Date: Wed, 05 Nov 2008 11:31:44 -0600 Message-ID: <1225906304.26835.75.camel@localhost.localdomain> References: <1225836860.15410.32.camel@localhost.localdomain> <200811052316.47127.rusty@rustcorp.com.au> <4911A87A.4010209@us.ibm.com> <1225902738.26835.51.camel@localhost.localdomain> <4911D70B.8000905@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Rusty Russell , kvm-ppc , kvm To: Anthony Liguori Return-path: Received: from e8.ny.us.ibm.com ([32.97.182.138]:48348 "EHLO e8.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753004AbYKERdD (ORCPT ); Wed, 5 Nov 2008 12:33:03 -0500 In-Reply-To: <4911D70B.8000905@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, 2008-11-05 at 11:25 -0600, Anthony Liguori wrote: > > I think we should just have a VIRTIO_PFN_SHIFT define that is > architecture specific. > > On x86, it'll be 4k. You can make it whatever you want for PPC. > Fixing all architectures to be 4k is going to suck for architectures > with < 4k pages. So we're now in agreement that it should be hardcoded. I don't see much value in making the actual value arch-specific, but either way it will solve (at least part of, and maybe all of) my problem. Rusty? -- Hollis Blanchard IBM Linux Technology Center