From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hollis Blanchard <hollisb@us.ibm.com>
Subject: Re: large page size virtio issues
Date: Wed, 05 Nov 2008 11:46:28 -0600
Message-ID: <1225907188.26835.82.camel@localhost.localdomain>
References: <1225836860.15410.32.camel@localhost.localdomain>
	 <200811052316.47127.rusty@rustcorp.com.au>  <4911A87A.4010209@us.ibm.com>
	 <1225902738.26835.51.camel@localhost.localdomain>
	 <4911D70B.8000905@us.ibm.com>
	 <1225906304.26835.75.camel@localhost.localdomain>
	 <4911D8F6.9070602@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	kvm-ppc <kvm-ppc@vger.kernel.org>, kvm <kvm@vger.kernel.org>
To: Anthony Liguori <aliguori@us.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e34.co.us.ibm.com ([32.97.110.152]:57979 "EHLO
	e34.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752423AbYKERqb (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 5 Nov 2008 12:46:31 -0500
In-Reply-To: <4911D8F6.9070602@us.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, 2008-11-05 at 11:33 -0600, Anthony Liguori wrote:
> Hollis Blanchard wrote:
> > On Wed, 2008-11-05 at 11:25 -0600, Anthony Liguori wrote:
> >   
> >> I think we should just have a VIRTIO_PFN_SHIFT define that is 
> >> architecture specific.
> >>
> >> On x86, it'll be 4k.  You can make it whatever you want for PPC.
> >> Fixing all architectures to be 4k is going to suck for architectures
> >> with < 4k pages.
> >>     
> >
> > So we're now in agreement that it should be hardcoded. I don't see much
> > value in making the actual value arch-specific, but either way it will
> > solve (at least part of, and maybe all of) my problem. Rusty?
> >   
> 
> When you balloon pages, you need to pass something that points to the 
> beginning of a page boundary.  If your page size is 2k, then if you are 
> only able to pass 4k addresses, you can't below any page that happens to 
> not be 4k aligned.
> 
> If you were going to make it common across all architectures, you would 
> have to make it the smallest possible page size and that would break x86 
> backwards compatibility.

OK, makes sense to me.

-- 
Hollis Blanchard
IBM Linux Technology Center