Re: [PATCH] kvm: ppc: fix Kconfig constraints

[Hollis Blanchard <hollisb@us.ibm.com>]

On Fri, 2008-11-07 at 13:10 -0600, Hollis Blanchard wrote:
> Make sure that CONFIG_KVM cannot be selected without processor support
> (currently, 440 is the only processor implementation available).
> 
> Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>
> 
> diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
> --- a/arch/powerpc/kvm/Kconfig
> +++ b/arch/powerpc/kvm/Kconfig
> @@ -15,24 +15,23 @@ if VIRTUALIZATION
>  if VIRTUALIZATION
> 
>  config KVM
> -	bool "Kernel-based Virtual Machine (KVM) support"
> -	depends on EXPERIMENTAL
> +	bool
>  	select PREEMPT_NOTIFIERS
>  	select ANON_INODES
> +	default n

The "default n" isn't needed. Updated patch below.

kvm: ppc: fix Kconfig constraints

Make sure that CONFIG_KVM cannot be selected without processor support
(currently, 440 is the only processor implementation available).

Signed-off-by: Hollis Blanchard <hollisb@us.ibm.com>

diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
--- a/arch/powerpc/kvm/Kconfig
+++ b/arch/powerpc/kvm/Kconfig
@@ -15,24 +15,22 @@ if VIRTUALIZATION
 if VIRTUALIZATION
 
 config KVM
-	bool "Kernel-based Virtual Machine (KVM) support"
-	depends on EXPERIMENTAL
+	bool
 	select PREEMPT_NOTIFIERS
 	select ANON_INODES
+
+config KVM_440
+	bool "KVM support for PowerPC 440 processors"
+	depends on EXPERIMENTAL && 44x
+	select KVM
 	---help---
-	  Support hosting virtualized guest machines. You will also
-	  need to select one or more of the processor modules below.
+	  Support running unmodified 440 guest kernels in virtual machines on
+	  440 host processors.
 
 	  This module provides access to the hardware capabilities through
 	  a character device node named /dev/kvm.
 
 	  If unsure, say N.
-
-config KVM_440
-	bool "KVM support for PowerPC 440 processors"
-	depends on KVM && 44x
-	---help---
-	  KVM can run unmodified 440 guest kernels on 440 host processors.
 
 config KVM_TRACE
 	bool "KVM trace support"


-- 
Hollis Blanchard
IBM Linux Technology Center