From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: Re: [PATCH] kvm: ppc: fix Kconfig constraints Date: Fri, 07 Nov 2008 13:15:13 -0600 Message-ID: <1226085313.9309.26.camel@localhost.localdomain> References: <7ef9d93760395985e11f.1226085033@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: kvm-ppc@vger.kernel.org, kvm@vger.kernel.org To: avi@redhat.com Return-path: Received: from e32.co.us.ibm.com ([32.97.110.150]:37812 "EHLO e32.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750962AbYKGTPP (ORCPT ); Fri, 7 Nov 2008 14:15:15 -0500 In-Reply-To: <7ef9d93760395985e11f.1226085033@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, 2008-11-07 at 13:10 -0600, Hollis Blanchard wrote: > Make sure that CONFIG_KVM cannot be selected without processor support > (currently, 440 is the only processor implementation available). > > Signed-off-by: Hollis Blanchard > > diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig > --- a/arch/powerpc/kvm/Kconfig > +++ b/arch/powerpc/kvm/Kconfig > @@ -15,24 +15,23 @@ if VIRTUALIZATION > if VIRTUALIZATION > > config KVM > - bool "Kernel-based Virtual Machine (KVM) support" > - depends on EXPERIMENTAL > + bool > select PREEMPT_NOTIFIERS > select ANON_INODES > + default n The "default n" isn't needed. Updated patch below. kvm: ppc: fix Kconfig constraints Make sure that CONFIG_KVM cannot be selected without processor support (currently, 440 is the only processor implementation available). Signed-off-by: Hollis Blanchard diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig --- a/arch/powerpc/kvm/Kconfig +++ b/arch/powerpc/kvm/Kconfig @@ -15,24 +15,22 @@ if VIRTUALIZATION if VIRTUALIZATION config KVM - bool "Kernel-based Virtual Machine (KVM) support" - depends on EXPERIMENTAL + bool select PREEMPT_NOTIFIERS select ANON_INODES + +config KVM_440 + bool "KVM support for PowerPC 440 processors" + depends on EXPERIMENTAL && 44x + select KVM ---help--- - Support hosting virtualized guest machines. You will also - need to select one or more of the processor modules below. + Support running unmodified 440 guest kernels in virtual machines on + 440 host processors. This module provides access to the hardware capabilities through a character device node named /dev/kvm. If unsure, say N. - -config KVM_440 - bool "KVM support for PowerPC 440 processors" - depends on KVM && 44x - ---help--- - KVM can run unmodified 440 guest kernels on 440 host processors. config KVM_TRACE bool "KVM trace support" -- Hollis Blanchard IBM Linux Technology Center