From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hollis Blanchard Subject: RE: [PATCH] kvm: ppc: stop leaking host memory on VM exit Date: Tue, 25 Nov 2008 10:52:11 -0600 Message-ID: <1227631931.7434.9.camel@localhost.localdomain> References: <1227548258.17746.11.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Avi Kivity , kvm-ppc , kvm To: Liu Yu Return-path: In-Reply-To: Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org On Tue, 2008-11-25 at 16:32 +0800, Liu Yu wrote: > > -----Original Message----- > > From: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > [mailto:kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Hollis Blanchard > > Sent: Tuesday, November 25, 2008 1:38 AM > > To: Avi Kivity > > Cc: kvm-ppc; kvm > > Subject: [PATCH] kvm: ppc: stop leaking host memory on VM exit > > > > When the VM exits, we must call put_page() for every page > > referenced in the > > shadow TLB. > > > > Without this patch, we usually leak 30-50 host pages (120 - > > 200 KiB with 4 KiB > > pages). The maximum number of pages leaked is the size of our > > shadow TLB, 64 > > pages. > > > > Signed-off-by: Hollis Blanchard > > Need it also to _tlbia() at vcpu_uninit? No, because by the time we hit kvm_arch_vcpu_uninit(), kvm_arch_vcpu_put() has already been called. -- Hollis Blanchard IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html